RE: [PATCH v3 05/13] serial: rsci: Drop unused TDR register

[Biju Das <biju.das.jz@bp.renesas.com>]

Hi Geert,

Thanks for the feedback.

> -----Original Message-----
> From: Geert Uytterhoeven <geert@linux-m68k.org>
> Sent: 21 November 2025 15:01
> Subject: Re: [PATCH v3 05/13] serial: rsci: Drop unused TDR register
> 
> On Fri, 14 Nov 2025 at 11:52, Biju <biju.das.au@gmail.com> wrote:
> > From: Biju Das <biju.das.jz@bp.renesas.com>
> >
> > Drop the unused TDR register-related macros.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> > --- a/drivers/tty/serial/rsci.c
> > +++ b/drivers/tty/serial/rsci.c
> > @@ -35,12 +35,6 @@ MODULE_IMPORT_NS("SH_SCI");
> >  #define RDR_FPER               BIT(11) /* FIFO Parity Error */
> >  #define RDR_RDAT_MSK           GENMASK(8, 0)
> >
> > -/* TDR (Transmit Data Register) */
> > -#define TDR_MPBT               BIT(9)  /* Multiprocessor Transfer */
> 
> Might be useful, one day. But all other bits do not have defines yet anyway.
> 
> > -#define TDR_TDAT_9BIT_LSHIFT   0
> > -#define TDR_TDAT_9BIT_VAL      0x1FF
> > -#define TDR_TDAT_9BIT_MSK      (TDR_TDAT_9BIT_VAL << TDR_TDAT_9BIT_LSHIFT)
> 
> I agree this is rather useless.

OK.

Cheers,
Biju