From: Johan Hovold <johan@kernel.org>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Mychaela N . Falconia" <falcon@freecalypso.org>,
linux-serial@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] USB: serial: ftdi_sio: add support for FreeCalypso DUART28C adapter
Date: Tue, 1 Dec 2020 09:55:08 +0100 [thread overview]
Message-ID: <X8YE7H+hdUY0WS9B@localhost> (raw)
In-Reply-To: <8f38320e-0f1c-c8a0-208e-2fa689be52f0@kernel.org>
On Tue, Dec 01, 2020 at 07:54:10AM +0100, Jiri Slaby wrote:
> On 30. 11. 20, 16:37, Johan Hovold wrote:
> > --- a/drivers/usb/serial/ftdi_sio.c
> > +++ b/drivers/usb/serial/ftdi_sio.c
> ...
> > @@ -2386,6 +2393,21 @@ static int ftdi_stmclite_probe(struct usb_serial *serial)
> > return 0;
> > }
> >
> > +/*
> > + * FreeCalypso DUART28C is an FT2232D-based USB to dual UART adapter
> > + * with a special quirk: Channel B RTS and DTR outputs (BDBUS2 and BDBUS4
> > + * on the chip) have been repurposed to drive PWON and RESET controls.
> > + */
> > +static void ftdi_duart28c_setup(struct usb_serial_port *port)
> > +{
> > + struct usb_serial *serial = port->serial;
> > + struct usb_interface *intf = serial->interface;
> > + int ifnum = intf->cur_altsetting->desc.bInterfaceNumber;
> > +
> > + if (ifnum == 1)
> > + tty_port_set_nordy(&port->port, 1);
>
> So s/1/true, provided the parameter is defined as bool now.
Also here I'm following the convention used for the other port-flag
helper which are used with numerical constants (just about) consistently
throughout the tree.
Johan
next prev parent reply other threads:[~2020-12-01 8:55 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 15:37 [PATCH 0/5] tty: add flag to suppress ready signalling on open Johan Hovold
2020-11-30 15:37 ` [PATCH 1/5] tty: add port " Johan Hovold
2020-11-30 23:36 ` Mychaela Falconia
2020-12-01 5:49 ` Jiri Slaby
2020-12-01 7:09 ` Mychaela Falconia
2020-12-01 7:16 ` Jiri Slaby
2020-12-01 8:46 ` Johan Hovold
2020-11-30 15:37 ` [PATCH 2/5] serial: core: add sysfs attribute " Johan Hovold
2020-11-30 18:27 ` Andy Shevchenko
2020-12-01 8:21 ` Johan Hovold
2020-12-01 10:55 ` Andy Shevchenko
2020-12-01 11:05 ` Johan Hovold
2020-12-01 11:19 ` Andy Shevchenko
2020-12-01 13:22 ` Johan Hovold
2020-12-01 13:49 ` Andy Shevchenko
2020-12-01 17:43 ` Johan Hovold
2020-12-01 16:44 ` Greg Kroah-Hartman
2020-12-01 17:24 ` Johan Hovold
2020-11-30 15:37 ` [PATCH 3/5] USB: serial: " Johan Hovold
2020-11-30 18:29 ` Andy Shevchenko
2020-11-30 15:37 ` [PATCH 4/5] USB: serial: ftdi_sio: pass port to quirk port_probe functions Johan Hovold
2020-11-30 15:37 ` [PATCH 5/5] USB: serial: ftdi_sio: add support for FreeCalypso DUART28C adapter Johan Hovold
2020-12-01 6:54 ` Jiri Slaby
2020-12-01 8:55 ` Johan Hovold [this message]
2020-11-30 21:22 ` [PATCH 0/5] tty: add flag to suppress ready signalling on open Mychaela Falconia
2020-12-01 7:14 ` Jiri Slaby
2020-12-01 7:18 ` Mychaela Falconia
2020-12-02 11:48 ` Johan Hovold
2020-12-04 6:58 ` Jiri Slaby
2020-12-08 9:30 ` Johan Hovold
2020-12-01 8:40 ` Johan Hovold
2020-12-01 10:48 ` Andy Shevchenko
2020-12-01 10:58 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X8YE7H+hdUY0WS9B@localhost \
--to=johan@kernel.org \
--cc=falcon@freecalypso.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).