From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Kumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com>,
jirislaby@kernel.org, ilpo.jarvinen@linux.intel.com,
deller@gmx.de, geert+renesas@glider.be,
phil.edworthy@renesas.com, matthew.gerlach@linux.intel.com,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH tty-next] serial: 8250_pci1xxxx: Disable SERIAL_8250_PCI1XXXX config by default
Date: Wed, 1 Mar 2023 17:52:58 +0200 [thread overview]
Message-ID: <Y/902nTSA05VY3i5@smile.fi.intel.com> (raw)
In-Reply-To: <Y/82Ehzj2+FgIRh3@kroah.com>
On Wed, Mar 01, 2023 at 12:25:06PM +0100, Greg KH wrote:
> On Wed, Mar 01, 2023 at 03:39:30PM +0530, Kumaravel Thiagarajan wrote:
> > Disable SERIAL_8250_PCI1XXXX config by default
>
> Why?
>
> Please read the kernel documentation for how to write a good changelog
> text.
Kumaravel, hint for you: Take what Linus had written in the discussion of
Greg's pull request. It mainly explains it all.
> > Signed-off-by: Kumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com>
>
> What commit id does this fix?
Another hint: this lacks so called Fixes tag. You may read about it in the
documentation.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-03-01 15:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 10:09 [PATCH tty-next] serial: 8250_pci1xxxx: Disable SERIAL_8250_PCI1XXXX config by default Kumaravel Thiagarajan
2023-03-01 11:25 ` Greg KH
2023-03-01 15:52 ` Andy Shevchenko [this message]
2023-03-02 7:03 ` Kumaravel.Thiagarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/902nTSA05VY3i5@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=deller@gmx.de \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=kumaravel.thiagarajan@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=matthew.gerlach@linux.intel.com \
--cc=phil.edworthy@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox