From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEF68C636CD for ; Fri, 10 Feb 2023 15:56:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232244AbjBJP4l (ORCPT ); Fri, 10 Feb 2023 10:56:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232340AbjBJP4k (ORCPT ); Fri, 10 Feb 2023 10:56:40 -0500 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CF3678D5A; Fri, 10 Feb 2023 07:56:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676044599; x=1707580599; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=fkT5K6peTGGXSVyjcxxXx7c6n3QEMd4i+IqyHTTd1HM=; b=BcV9MaookHpC3JvS2ll3P96NRQpfYrGx4t75VH35RtUsT6uE/1pho2zH Fgx2XD2bqwb818Wn3njqIxe1u0fWpGVgUDaVTGbS3AFOjwLhYqn1Dhoy0 OwgQ7jUun6Eli+lhfgXcTXI4JJKvtKU+jG15uSYrlPEoyOzjmaKZ9SIZn RF/EVavaHaJuQH3I8m0YAkCB2faQYjmykROg/KpGnlEcclQbUWu48V5tw yq7vGXSDyRCwgXFEBJ8pbi7PXTM0PR+2J/PMxnx34FwbbP2CgzYC5Qtfr CYFTJ/31F8Lmtoviy4XqvAMetZS3r4zeYp08WnXSgbrYXY4HN/CcmtqU0 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10617"; a="416675311" X-IronPort-AV: E=Sophos;i="5.97,287,1669104000"; d="scan'208";a="416675311" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2023 07:56:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10617"; a="996988881" X-IronPort-AV: E=Sophos;i="5.97,287,1669104000"; d="scan'208";a="996988881" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga005.fm.intel.com with ESMTP; 10 Feb 2023 07:56:35 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pQVlJ-005742-0G; Fri, 10 Feb 2023 17:56:33 +0200 Date: Fri, 10 Feb 2023 17:56:32 +0200 From: Andy Shevchenko To: Biju Das Cc: Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Greg Kroah-Hartman , Jiri Slaby , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , "Maciej W. Rozycki" , Eric Tremblay , Wander Lairson Costa , linux-serial , Geert Uytterhoeven , Fabrizio Castro , "linux-renesas-soc@vger.kernel.org" Subject: Re: [PATCH 1/3] serial: 8250: Identify Renesas RZ/V2M 16750 UART Message-ID: References: <20230209132630.194947-1-biju.das.jz@bp.renesas.com> <20230209132630.194947-2-biju.das.jz@bp.renesas.com> <4470e054-ebe6-b3ca-ffd7-1c7c3ae09f1a@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Fri, Feb 10, 2023 at 11:53:43AM +0000, Biju Das wrote: > > Subject: Re: [PATCH 1/3] serial: 8250: Identify Renesas RZ/V2M 16750 UART > > On Fri, Feb 10, 2023 at 07:14:54AM +0000, Biju Das wrote: ... > > What I don't like is increasing quirks in the 8250_port. Can't you simply > > use FIXED_PORT facility? > > Again, look how 8250_mid is written. > > Coll. I have referred 8250_mid and added below changes and it is working as expected. > I will sent next version after incorporating comments from Geert and ilpo. Glad to hear that and thank you for cooperation! -- With Best Regards, Andy Shevchenko