From: Thierry Reding <thierry.reding@gmail.com>
To: Kartik <kkartik@nvidia.com>
Cc: ldewangan@nvidia.com, gregkh@linuxfoundation.org,
jirislaby@kernel.org, jonathanh@nvidia.com, alan@linux.intel.com,
swarren@nvidia.com, akhilrajeev@nvidia.com,
linux-serial@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] serial: tegra: Read DMA status before terminating
Date: Tue, 18 Oct 2022 17:19:14 +0200 [thread overview]
Message-ID: <Y07D8qIPJYrwqWPM@orome> (raw)
In-Reply-To: <1666105086-17326-1-git-send-email-kkartik@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 711 bytes --]
On Tue, Oct 18, 2022 at 08:28:06PM +0530, Kartik wrote:
> Read the DMA status before terminating the DMA, as doing so deletes
> the DMA desc.
>
> Also, to get the correct transfer status information, pause the DMA
> using dmaengine_pause() before reading the DMA status.
>
> Fixes: e9ea096dd225 ("serial: tegra: add serial driver")
>
> Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
> Signed-off-by: Kartik <kkartik@nvidia.com>
> ---
> v1->v2:
> * Pause the DMA before reading the DMA status.
> * Updated commit message.
>
> drivers/tty/serial/serial-tegra.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
Seems fine:
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-10-18 15:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 14:58 [PATCH v2] serial: tegra: Read DMA status before terminating Kartik
2022-10-18 15:19 ` Thierry Reding [this message]
2022-10-19 9:12 ` Ilpo Järvinen
2022-10-19 9:48 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y07D8qIPJYrwqWPM@orome \
--to=thierry.reding@gmail.com \
--cc=akhilrajeev@nvidia.com \
--cc=alan@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=kkartik@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).