From: Greg KH <gregkh@linuxfoundation.org>
To: "Starke, Daniel" <daniel.starke@siemens.com>
Cc: "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"jirislaby@kernel.org" <jirislaby@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] tty: n_gsm: make n_gsm line number configurable
Date: Thu, 13 Oct 2022 14:57:27 +0200 [thread overview]
Message-ID: <Y0gLN5b4TH43NhtZ@kroah.com> (raw)
In-Reply-To: <DB9PR10MB58818736388F209396CEA749E0259@DB9PR10MB5881.EURPRD10.PROD.OUTLOOK.COM>
On Thu, Oct 13, 2022 at 11:09:02AM +0000, Starke, Daniel wrote:
> > > --- a/include/uapi/linux/gsmmux.h
> > > +++ b/include/uapi/linux/gsmmux.h
> > > @@ -19,7 +19,9 @@ struct gsm_config
> > > unsigned int mtu;
> > > unsigned int k;
> > > unsigned int i;
> > > - unsigned int unused[8]; /* Padding for expansion without
> > > + unsigned short numValid;
> > > + unsigned short num;
> >
> > This would never work anyway (hint "short" is not a valid uapi data
> > type...)
>
> I am surprised about this as gsm_netconfig already uses unsigned short.
How does netconfig pass data to/from userspace? Through ioctls or
netlink?
thanks,
greg k-h
prev parent reply other threads:[~2022-10-13 12:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 6:17 [PATCH 1/1] tty: n_gsm: make n_gsm line number configurable D. Starke
2022-10-12 6:50 ` Greg KH
2022-10-13 11:09 ` Starke, Daniel
2022-10-13 12:57 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0gLN5b4TH43NhtZ@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=daniel.starke@siemens.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).