From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 147C2C4332F for ; Fri, 21 Oct 2022 14:14:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231355AbiJUOOF (ORCPT ); Fri, 21 Oct 2022 10:14:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231329AbiJUOOE (ORCPT ); Fri, 21 Oct 2022 10:14:04 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0EA3727BB32; Fri, 21 Oct 2022 07:14:04 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id BFD991F900; Fri, 21 Oct 2022 14:14:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1666361642; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lg47ticWAesjozzNRlpOg0836L4TUDvbY874Y7InfJE=; b=Leg3fTuPY+qDWuwBrQprly4zHHQbg4dStKVHcQTU1rbDsXhFkqhchJYtpeFu/zOYXrqC4l J2kbaPStzlFUAh+5tFvru1/IcmuKEkFov0mS607qFde1Iv3qDKserjU78SD9xqnSUb+28b X/PfbVUs9qiDF/BFSrgixosznekTIL0= Received: from suse.cz (unknown [10.100.201.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 549942C141; Fri, 21 Oct 2022 14:14:02 +0000 (UTC) Date: Fri, 21 Oct 2022 16:14:01 +0200 From: Petr Mladek To: John Ogness Cc: Sergey Senozhatsky , Steven Rostedt , Thomas Gleixner , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Alim Akhtar , Greg Kroah-Hartman , Jiri Slaby , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH printk v2 14/38] tty: serial: samsung_tty: use console_is_enabled() Message-ID: References: <20221019145600.1282823-1-john.ogness@linutronix.de> <20221019145600.1282823-15-john.ogness@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221019145600.1282823-15-john.ogness@linutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Wed 2022-10-19 17:01:36, John Ogness wrote: > Replace (console->flags & CON_ENABLED) usage with console_is_enabled(). > > Signed-off-by: John Ogness > --- > drivers/tty/serial/samsung_tty.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c > index 77d1363029f5..8142a0e53ffa 100644 > --- a/drivers/tty/serial/samsung_tty.c > +++ b/drivers/tty/serial/samsung_tty.c > @@ -1732,7 +1732,7 @@ static void __init s3c24xx_serial_register_console(void) > > static void s3c24xx_serial_unregister_console(void) > { > - if (s3c24xx_serial_console.flags & CON_ENABLED) > + if (console_is_enabled(&s3c24xx_serial_console)) > unregister_console(&s3c24xx_serial_console); > } As on many other locations, it would be better to check if the console is in console_list. CON_ENABLED might be disabled even when the console is registered. It would be nice to fix this. But it might be done later. Reviewed-by: Petr Mladek Best Regards, Petr