From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1302EC433FE for ; Thu, 10 Nov 2022 15:18:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231473AbiKJPSl (ORCPT ); Thu, 10 Nov 2022 10:18:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231409AbiKJPSN (ORCPT ); Thu, 10 Nov 2022 10:18:13 -0500 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDEBB31DCC for ; Thu, 10 Nov 2022 07:18:12 -0800 (PST) Received: by mail-ed1-x534.google.com with SMTP id v27so3597442eda.1 for ; Thu, 10 Nov 2022 07:18:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TnbvJ2aNd/N4qPmGQHgGv1wyv/KitPYgnCYQxHNl5yc=; b=STUtE1y18DQBqcdpzuDwOSXPZ13/gNh8YkjwWCd0EFji3vWoV/Q+siSjXq5bjNysOx 4cH5Vj08sKiHa1oI3ngPSGWGkVHv4tZvyT2HHNxyvcwyj42mHxHoVf91t0h8ltJngJnQ X6pmsLISMzLboUUe+d6BnTe8xP0CxeH666LWdMTWW5fEtSfLzZ85Y26ngYBd7isEVvI9 ZXd0yXZYIpSUrv3FTKYfuXvQ/eiB6mNRg/q2w5tkVvPZilPVIKX9qT7QLimsXe2Fy1mv 5ET5ZbciqYjlEZ7powNKjcY/I17J2fqkefvtJ6Np7IcJ3AuVBzCr2AXLs1XYT1KsUyUy hfxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TnbvJ2aNd/N4qPmGQHgGv1wyv/KitPYgnCYQxHNl5yc=; b=yjxMur9EyH8ac26Ooyk36EUfg8Zm55dgQAAPg16cjAe8DmvimRbrrCzOy4KRIK9QZ2 BG8+THGO5TE8MZJgGqAMufpRZUlFpYaVs8DT+p7Sk04iFsgNIeDhn9EhAddQIeLhgbJo QirPpS/Gsimrle+ESyknP0YrBEqM8LotwdcJFAF9Ed87pa80Nn8j/LWdOKjR6MBNEOxe FZuKBj3y8U7MyOgNQvU9OVcKbQd5v0Lh4ROsLA75SHYecfW0gBLS0HTgAEX8roXdzTd/ /52i9Jvcz2hQ1m67QEKsXpyWMFgqkbmHpJCJZrT8eZ+jdI4l1oBTHcqoKB649H2w/fvn iHhg== X-Gm-Message-State: ACrzQf0ia4uGjO1dxbkNb/LxFdzlA22zXXbBo86Z614rs8nJxQjHNHQU NyXd0b7XdQ7UvtqU08DP3mectQ== X-Google-Smtp-Source: AMsMyM7A2A2Tt1JxgZ82rllwHec1SazSu8WJQM2KYh7x6hVkjuwcr8WdaWIGdmbf3PCd/TlGC6P+UA== X-Received: by 2002:a50:ef17:0:b0:45b:4a4b:478c with SMTP id m23-20020a50ef17000000b0045b4a4b478cmr2414848eds.317.1668093491324; Thu, 10 Nov 2022 07:18:11 -0800 (PST) Received: from frostfish ([82.132.184.39]) by smtp.gmail.com with ESMTPSA id l22-20020aa7cad6000000b0045b4b67156fsm8561373edt.45.2022.11.10.07.18.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 07:18:10 -0800 (PST) Date: Thu, 10 Nov 2022 15:18:07 +0000 From: Daniel Thompson To: John Ogness Cc: Petr Mladek , Sergey Senozhatsky , Steven Rostedt , Thomas Gleixner , linux-kernel@vger.kernel.org, Jason Wessel , Douglas Anderson , Greg Kroah-Hartman , Jiri Slaby , kgdb-bugreport@lists.sourceforge.net, linux-serial@vger.kernel.org Subject: Re: [PATCH printk v3 38/40] tty: serial: kgdboc: use console_list_lock to trap exit Message-ID: References: <20221107141638.3790965-1-john.ogness@linutronix.de> <20221107141638.3790965-39-john.ogness@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221107141638.3790965-39-john.ogness@linutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Mon, Nov 07, 2022 at 03:22:36PM +0106, John Ogness wrote: > kgdboc_earlycon_init() uses the console_lock to ensure that no consoles > are unregistered until the kgdboc_earlycon is setup. The console_list_lock > should be used instead because list synchronization responsibility will > be removed from the console_lock in a later change. > > Signed-off-by: John Ogness I've not looked at the other patches in the series to understand the future tense here (e.g. why we need intermediate patches like this one). However I've no objections to the change so: Reviewed-by: Daniel Thompson Daniel. > --- > drivers/tty/serial/kgdboc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/tty/serial/kgdboc.c b/drivers/tty/serial/kgdboc.c > index 8c2b7ccdfebf..a3ed9b34e2ab 100644 > --- a/drivers/tty/serial/kgdboc.c > +++ b/drivers/tty/serial/kgdboc.c > @@ -558,13 +558,13 @@ static int __init kgdboc_earlycon_init(char *opt) > */ > > /* > - * Hold the console_lock to guarantee that no consoles are > + * Hold the console_list_lock to guarantee that no consoles are > * unregistered until the kgdboc_earlycon setup is complete. > * Trapping the exit() callback relies on exit() not being > * called until the trap is setup. This also allows safe > * traversal of the console list and race-free reading of @flags. > */ > - console_lock(); > + console_list_lock(); > for_each_console(con) { > if (con->write && con->read && > (con->flags & (CON_BOOT | CON_ENABLED)) && > @@ -606,7 +606,7 @@ static int __init kgdboc_earlycon_init(char *opt) > } > > unlock: > - console_unlock(); > + console_list_unlock(); > > /* Non-zero means malformed option so we always return zero */ > return 0; > -- > 2.30.2 >