From: Tony Lindgren <tony@atomide.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andy Shevchenko <andriy.shevchenko@intel.com>,
Jiri Slaby <jirislaby@kernel.org>,
Johan Hovold <johan@kernel.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-serial <linux-serial@vger.kernel.org>,
linux-omap@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v4 1/1] serial: core: Start managing serial controllers to enable runtime PM
Date: Mon, 12 Dec 2022 14:53:20 +0200 [thread overview]
Message-ID: <Y5ckQKmQYwi8aWgi@atomide.com> (raw)
In-Reply-To: <ced9e9ea-317e-f2a2-d42f-97c2cd39f11b@linux.intel.com>
* Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> [221212 12:49]:
> On Mon, 12 Dec 2022, Tony Lindgren wrote:
>
> > Hi Ilpo,
> >
> > * Tony Lindgren <tony@atomide.com> [221208 11:13]:
> > > * Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> [221208 10:48]:
> > > > With the other patch on top of this, yes, I did see uninitialized
> > > > port->port_dev already in serial_core_add_one_port()->uart_configure_port().
> > > > While that could be solved by removing the pm_runtime_*() calls from
> > > > there, I think it's a generic problem because after
> > > > serial_core_add_one_port() the port can have anything happening on it, no?
> > >
> > > OK. Sounds like it should get sorted out by moving the call to
> > > serial_core_add_one_port() to happen after the devices are created.
> >
> > Can you give a try with the patch below and see if it works for you?
>
> This one worked, yes.
OK good to hear. I'll send out v5 after -rc1 then.
Thanks,
Tony
prev parent reply other threads:[~2022-12-12 12:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 12:43 [RFC PATCH v4 1/1] serial: core: Start managing serial controllers to enable runtime PM Tony Lindgren
2022-12-07 20:22 ` Andy Shevchenko
2022-12-07 20:28 ` Andy Shevchenko
2022-12-08 5:52 ` Tony Lindgren
2022-12-08 6:06 ` Tony Lindgren
2022-12-08 9:12 ` Ilpo Järvinen
2022-12-08 10:15 ` Tony Lindgren
2022-12-08 10:48 ` Ilpo Järvinen
2022-12-08 11:13 ` Tony Lindgren
2022-12-12 7:09 ` Tony Lindgren
2022-12-12 12:49 ` Ilpo Järvinen
2022-12-12 12:53 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5ckQKmQYwi8aWgi@atomide.com \
--to=tony@atomide.com \
--cc=andriy.shevchenko@intel.com \
--cc=bigeasy@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).