From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1010CC4332F for ; Sat, 24 Dec 2022 08:40:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229487AbiLXIkT (ORCPT ); Sat, 24 Dec 2022 03:40:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229485AbiLXIkS (ORCPT ); Sat, 24 Dec 2022 03:40:18 -0500 Received: from msg-1.mailo.com (msg-1.mailo.com [213.182.54.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9F3B12D3E; Sat, 24 Dec 2022 00:40:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1671871208; bh=N/uQxjT+1+iGIoYVplsII3AkhcPL0am2LgaSxxryuWM=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To; b=LG+VZmfV/9mkT+gbHT2Kb8Do2V8XPevFJSHePhm770sqCBblasva9gktaLnBcvdu6 Nb+A1eR1B27/IrpPSMrThy1XeuNohX9ZZyL6WXCPOICdftWTWvAUoGDlxAIRyAS4YH iWb4zm0ILfO4qwgMeRji8dcBu1qrh300R8KjG/lM= Received: by b-1.in.mailobj.net [192.168.90.11] with ESMTP via ip-206.mailobj.net [213.182.55.206] Sat, 24 Dec 2022 09:40:08 +0100 (CET) X-EA-Auth: Gagyupn+vvbazE/cHYUasNTGfC1/PKzXCTPk2qcRVlMJnST/ehCQ4jmIVe5ClO1X/S6ScWbLypWXPgn1svmJqGQOQQX4VR9p Date: Sat, 24 Dec 2022 14:10:02 +0530 From: Deepak R Varma To: Greg Kroah-Hartman Cc: "Maciej W. Rozycki" , Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Saurabh Singh Sengar , Praveen Kumar Subject: Re: [PATCH v2] tty: serial: dz: convert atomic_* to refcount_* APIs for irq_guard Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Sat, Dec 24, 2022 at 09:37:43AM +0100, Greg Kroah-Hartman wrote: > On Sat, Dec 24, 2022 at 01:47:12PM +0530, Deepak R Varma wrote: > > The refcount_* APIs are designed to address known issues with the > > atomic_t APIs for reference counting. They provide following distinct > > advantages: > > - protect the reference counters from overflow/underflow > > - avoid use-after-free errors > > - provide improved memory ordering guarantee schemes > > - neater and safer. > > Hence, replace the atomic_* APIs by their equivalent refcount_t > > API functions. > > > > This patch proposal address the following warnings generated by > > the atomic_as_refcounter.cocci coccinelle script > > atomic_add_return(-1, ...) > > > > Signed-off-by: Deepak R Varma > > --- > > This depends on the previous patch you sent, so why wasn't this a patch > series? Always send patches as a series, otherwise I would have > attempted to apply this one first and it would have failed. You will > recieve 0-day reports about that happening over the next few days as our > testing infrastructure will also be confused. My apologies. I will send in the patches in a series and highlight the dependency as well. Sorry. ./drv > > Please fix and resend all changes you wish to have done to this driver > together. > > thanks, > > greg k-h