From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7AC1C10F1B for ; Sat, 24 Dec 2022 08:37:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229937AbiLXIhv (ORCPT ); Sat, 24 Dec 2022 03:37:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229487AbiLXIht (ORCPT ); Sat, 24 Dec 2022 03:37:49 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF953B4BF; Sat, 24 Dec 2022 00:37:47 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 42F3D6020F; Sat, 24 Dec 2022 08:37:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 028CDC433D2; Sat, 24 Dec 2022 08:37:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1671871066; bh=d2QlW2jzxm0TheGGe7a2wTTUh4ptonZr6C3QaKWYxXc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iadjt2PB/+8hlq5sX0aFgfK0T8sL1rQnLHW6s3+sx17rYBsMB9sRXxGNBy1oc92Mx hbwtI7HyFV0CTdczeQj0pH4BxokJGe22rSu5IO2tKWeHZofZHaagRJnLavaB2iN3Lj lOjvP2EYFglCh0pDxQfioVks+iIVEU1D9M0H7nQM= Date: Sat, 24 Dec 2022 09:37:43 +0100 From: Greg Kroah-Hartman To: Deepak R Varma Cc: "Maciej W. Rozycki" , Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Saurabh Singh Sengar , Praveen Kumar Subject: Re: [PATCH v2] tty: serial: dz: convert atomic_* to refcount_* APIs for irq_guard Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Sat, Dec 24, 2022 at 01:47:12PM +0530, Deepak R Varma wrote: > The refcount_* APIs are designed to address known issues with the > atomic_t APIs for reference counting. They provide following distinct > advantages: > - protect the reference counters from overflow/underflow > - avoid use-after-free errors > - provide improved memory ordering guarantee schemes > - neater and safer. > Hence, replace the atomic_* APIs by their equivalent refcount_t > API functions. > > This patch proposal address the following warnings generated by > the atomic_as_refcounter.cocci coccinelle script > atomic_add_return(-1, ...) > > Signed-off-by: Deepak R Varma > --- This depends on the previous patch you sent, so why wasn't this a patch series? Always send patches as a series, otherwise I would have attempted to apply this one first and it would have failed. You will recieve 0-day reports about that happening over the next few days as our testing infrastructure will also be confused. Please fix and resend all changes you wish to have done to this driver together. thanks, greg k-h