From: Greg KH <gregkh@linuxfoundation.org>
To: Christina Quast <contact@christina-quast.de>
Cc: linux-serial@vger.kernel.org, ilpo.jarvinen@linux.intel.com,
daniel.beer@igorinstitute.com
Subject: Re: [PATCH tty-next v2 1/3] hid-ft260: Cleanup macro formatting
Date: Tue, 27 Dec 2022 08:25:21 +0100 [thread overview]
Message-ID: <Y6qd4TG8BSHd0KY1@kroah.com> (raw)
In-Reply-To: <20221226171549.73645-2-contact@christina-quast.de>
On Mon, Dec 26, 2022 at 06:15:47PM +0100, Christina Quast wrote:
> Wrap macro arguments in braces.
This says _what_ you did here, but no explaination of _why_ you did
this, or why it was even needed.
Please read the section entitled "The canonical patch format" in the
kernel file, Documentation/process/submitting-patches.rst for what is
needed in order to properly describe the change.
thanks,
greg k-h
next prev parent reply other threads:[~2022-12-27 7:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-26 17:15 [PATCH tty-next v2 0/3] hid-ft260 cleanups Christina Quast
2022-12-26 17:15 ` [PATCH tty-next v2 1/3] hid-ft260: Cleanup macro formatting Christina Quast
2022-12-26 18:00 ` Ilpo Järvinen
2022-12-27 7:25 ` Greg KH [this message]
2022-12-26 17:15 ` [PATCH tty-next v2 2/3] hid-ft260: Rename struct ft260_i2c_input_report Christina Quast
2022-12-26 17:15 ` [PATCH tty-next v2 3/3] hid-ft260: Change u8 to __u8 for hw facing structs Christina Quast
2022-12-27 8:45 ` Johan Hovold
[not found] ` <d9c0cc2c-c724-b641-80ce-e31336901410@christina-quast.de>
2022-12-27 9:48 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6qd4TG8BSHd0KY1@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=contact@christina-quast.de \
--cc=daniel.beer@igorinstitute.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).