From: "Gabriel L. Somlo" <gsomlo@gmail.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org, Jiri Slaby <jirislaby@kernel.org>,
Karol Gugala <kgugala@antmicro.com>,
Mateusz Holenko <mholenko@antmicro.com>,
Joel Stanley <joel@jms.id.au>,
linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>,
Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH 2/2] serial: liteuart: Correct error rollback
Date: Mon, 23 Jan 2023 12:42:39 -0500 [thread overview]
Message-ID: <Y87HD7kEVp5mO/85@errol.ini.cmu.edu> (raw)
In-Reply-To: <20230123173857.40695-3-ilpo.jarvinen@linux.intel.com>
On Mon, Jan 23, 2023 at 07:38:57PM +0200, Ilpo Järvinen wrote:
> Goto to the correct rollback label instead of directly returning.
>
> Fixes: 5602cf99dcdc ("serial: liteuart: add IRQ support for the RX path")
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---
> drivers/tty/serial/liteuart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/liteuart.c b/drivers/tty/serial/liteuart.c
> index ef557d59e4c8..192ad681de35 100644
> --- a/drivers/tty/serial/liteuart.c
> +++ b/drivers/tty/serial/liteuart.c
> @@ -313,7 +313,7 @@ static int liteuart_probe(struct platform_device *pdev)
>
> ret = platform_get_irq_optional(pdev, 0);
> if (ret < 0 && ret != -ENXIO)
> - return ret;
> + goto err_erase_id;
That was my mistake, sorry, and thanks for the super-quick fix! :)
Reviewed-by: Gabriel Somlo <gsomlo@gmail.com>
> if (ret > 0)
> port->irq = ret;
>
> --
> 2.30.2
>
next prev parent reply other threads:[~2023-01-23 17:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 17:38 [PATCH 0/2] serial: fix recently introduced problems in tty-next Ilpo Järvinen
2023-01-23 17:38 ` [PATCH 1/2] serial: qcom_geni: Fix variable naming Ilpo Järvinen
2023-01-23 17:38 ` [PATCH 2/2] serial: liteuart: Correct error rollback Ilpo Järvinen
2023-01-23 17:42 ` Gabriel L. Somlo [this message]
2023-01-23 17:50 ` [PATCH 0/2] serial: fix recently introduced problems in tty-next Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y87HD7kEVp5mO/85@errol.ini.cmu.edu \
--to=gsomlo@gmail.com \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=joel@jms.id.au \
--cc=kgugala@antmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mholenko@antmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox