linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Matthew Howell <mrhowel@g.clemson.edu>
Cc: linux-serial@vger.kernel.org, jeff.baldwin@sealevel.com,
	ryan.wenglarz@sealevel.com, matthew.howell@sealevel.com,
	darren.beeson@sealevel.com
Subject: Re: [PATCH v2] serial: exar: Add support for Sealevel 7xxxC serial cards
Date: Thu, 19 Jan 2023 17:57:44 +0100	[thread overview]
Message-ID: <Y8l2iFHi66NFaGGX@kroah.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2301191117110.21493@tstest-VirtualBox>

On Thu, Jan 19, 2023 at 11:23:51AM -0500, Matthew Howell wrote:
> 
> Add support for Sealevel 7xxxC serial cards.
> 
> This patch:
> * Adds IDs to recognize 7xxxC cards from Sealevel Systems.
> * Updates exar_pci_probe() to set nr_ports to last two bytes of primary
> dev ID for these cards.
> 
> Signed-off-by: Matthew Howell <matthew.howell@sealevel.com>
> 
> Moved "This patch..." above signed-off line.
> 
> Let me know if I need to make any more changes.

These lines need to go below the --- line, as the documentation asks,
otherwise they will show up in the changelog.

Also you need to list what changed in v2, again the documentation has
examples.

v3 please?

thanks,

greg k-h

  reply	other threads:[~2023-01-19 16:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-19 16:23 [PATCH v2] serial: exar: Add support for Sealevel 7xxxC serial cards Matthew Howell
2023-01-19 16:57 ` Greg KH [this message]
2023-01-19 16:57 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y8l2iFHi66NFaGGX@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=darren.beeson@sealevel.com \
    --cc=jeff.baldwin@sealevel.com \
    --cc=linux-serial@vger.kernel.org \
    --cc=matthew.howell@sealevel.com \
    --cc=mrhowel@g.clemson.edu \
    --cc=ryan.wenglarz@sealevel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).