Re: [PATCH 1/3] tty: serial: Add UART driver for Cortina-Access platform

Re: [PATCH 1/3] tty: serial: Add UART driver for Cortina-Access platform

[Greg Kroah-Hartman]

On Thu, Feb 18, 2021 at 06:42:09PM -0800, Alex Nemirovsky wrote:
> From: Jason Li <jason.li@cortina-access.com>
> 
> This driver supports Cortina Access UART IP integrated
> in most all CAXXXX line of SoCs. Earlycom is also supported
> 
> Signed-off-by: Jason Li <jason.li@cortina-access.com>
> Reviewed-by: Alex Nemirovsky <alex.nemirovsky@cortina-access.com>
> ---
>  MAINTAINERS                                |   5 +
>  drivers/tty/serial/Kconfig                 |  19 +
>  drivers/tty/serial/Makefile                |   1 +
>  drivers/tty/serial/serial_cortina-access.c | 798 +++++++++++++++++++++++++++++
>  include/uapi/linux/serial_core.h           |   3 +
>  5 files changed, 826 insertions(+)
>  create mode 100644 drivers/tty/serial/serial_cortina-access.c
> 
>  Change log
>   drivers/tty/serial/serial_cortina-access.c
>    v3:
>     - Remove usage of uintptr_t. Change to pointer to driver's private
>       structure instead.

Is this really a "v3"?  The subject lines do not show that, so I'm
totally confused as to what to review and what has been reviewed here.

Please fix this up and submit a "v4" so we know what is going on :)

thanks,

greg k-h

Re: [PATCH 1/3] tty: serial: Add UART driver for Cortina-Access platform

[Alex Nemirovsky]

> On Mar 23, 2021, at 2:22 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> 
> On Thu, Feb 18, 2021 at 06:42:09PM -0800, Alex Nemirovsky wrote:
>> From: Jason Li <jason.li@cortina-access.com>
>> 
>> This driver supports Cortina Access UART IP integrated
>> in most all CAXXXX line of SoCs. Earlycom is also supported
>> 
>> Signed-off-by: Jason Li <jason.li@cortina-access.com>
>> Reviewed-by: Alex Nemirovsky <alex.nemirovsky@cortina-access.com>
>> ---
>> MAINTAINERS                                |   5 +
>> drivers/tty/serial/Kconfig                 |  19 +
>> drivers/tty/serial/Makefile                |   1 +
>> drivers/tty/serial/serial_cortina-access.c | 798 +++++++++++++++++++++++++++++
>> include/uapi/linux/serial_core.h           |   3 +
>> 5 files changed, 826 insertions(+)
>> create mode 100644 drivers/tty/serial/serial_cortina-access.c
>> 
>> Change log
>>  drivers/tty/serial/serial_cortina-access.c
>>   v3:
>>    - Remove usage of uintptr_t. Change to pointer to driver's private
>>      structure instead.
> 
> Is this really a "v3"?  The subject lines do not show that, so I'm
> totally confused as to what to review and what has been reviewed here.
> 
> Please fix this up and submit a "v4" so we know what is going on :)

Could you recommend a method or a tool to update the commit subject id with a version prefix?
Currently we are doing a git format-patch and the subject line is automatically created without a 
version number. Do you just go in manual and edit the resulting patch contents file or do you use a 
tool to assist in this?
> 
> thanks,
> 
> greg k-h

Re: [PATCH 1/3] tty: serial: Add UART driver for Cortina-Access platform

[Greg Kroah-Hartman]

On Tue, Mar 23, 2021 at 07:28:51PM +0000, Alex Nemirovsky wrote:
> 
> 
> > On Mar 23, 2021, at 2:22 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> > 
> > On Thu, Feb 18, 2021 at 06:42:09PM -0800, Alex Nemirovsky wrote:
> >> From: Jason Li <jason.li@cortina-access.com>
> >> 
> >> This driver supports Cortina Access UART IP integrated
> >> in most all CAXXXX line of SoCs. Earlycom is also supported
> >> 
> >> Signed-off-by: Jason Li <jason.li@cortina-access.com>
> >> Reviewed-by: Alex Nemirovsky <alex.nemirovsky@cortina-access.com>
> >> ---
> >> MAINTAINERS                                |   5 +
> >> drivers/tty/serial/Kconfig                 |  19 +
> >> drivers/tty/serial/Makefile                |   1 +
> >> drivers/tty/serial/serial_cortina-access.c | 798 +++++++++++++++++++++++++++++
> >> include/uapi/linux/serial_core.h           |   3 +
> >> 5 files changed, 826 insertions(+)
> >> create mode 100644 drivers/tty/serial/serial_cortina-access.c
> >> 
> >> Change log
> >>  drivers/tty/serial/serial_cortina-access.c
> >>   v3:
> >>    - Remove usage of uintptr_t. Change to pointer to driver's private
> >>      structure instead.
> > 
> > Is this really a "v3"?  The subject lines do not show that, so I'm
> > totally confused as to what to review and what has been reviewed here.
> > 
> > Please fix this up and submit a "v4" so we know what is going on :)
> 
> Could you recommend a method or a tool to update the commit subject id with a version prefix?
> Currently we are doing a git format-patch and the subject line is automatically created without a 
> version number. Do you just go in manual and edit the resulting patch contents file or do you use a 
> tool to assist in this?

This is only 3 patches, they are easy to edit by hand...  :)

Anyway 'git format-patch' can do this automatically for you if you want,
see the -v or --reroll-count option.

thanks,

greg k-h

Re: [PATCH 1/3] tty: serial: Add UART driver for Cortina-Access platform

[Greg Kroah-Hartman]

On Thu, Feb 18, 2021 at 06:42:09PM -0800, Alex Nemirovsky wrote:
> +static struct cortina_uart_port *cortina_uart_ports;

Why is this not a per-device pointer?

> +static void __exit cortina_uart_exit(void)
> +{
> +	platform_driver_unregister(&serial_cortina_driver);
> +	uart_unregister_driver(&cortina_uart_driver);
> +	kfree(cortina_uart_ports);

Should not need to free this here, it should be tied to the device, not
the driver.


> +}
> +
> +module_init(cortina_uart_init);
> +module_exit(cortina_uart_exit);
> +
> +MODULE_AUTHOR("Cortina-Access Inc.");
> +MODULE_DESCRIPTION(" Cortina-Access UART driver");
> +MODULE_LICENSE("GPL");
> diff --git a/include/uapi/linux/serial_core.h b/include/uapi/linux/serial_core.h
> index 62c2204..1931892 100644
> --- a/include/uapi/linux/serial_core.h
> +++ b/include/uapi/linux/serial_core.h
> @@ -277,4 +277,7 @@
>  /* Freescale LINFlexD UART */
>  #define PORT_LINFLEXUART	122
>  
> +/* Cortina-Access UART */
> +#define PORT_CORTINA_ACCESS	123

Also, no need for this, right?  I would prefer to not add new ids if at
all possible.

thanks,

greg k-h

Re: [PATCH 1/3] tty: serial: Add UART driver for Cortina-Access platform

[Alex Nemirovsky]

Hi Greg,

> On Mar 23, 2021, at 2:24 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> 
> On Thu, Feb 18, 2021 at 06:42:09PM -0800, Alex Nemirovsky wrote:
>> +static struct cortina_uart_port *cortina_uart_ports;
> 
> Why is this not a per-device pointer?
> 
>> +static void __exit cortina_uart_exit(void)
>> +{
>> +	platform_driver_unregister(&serial_cortina_driver);
>> +	uart_unregister_driver(&cortina_uart_driver);
>> +	kfree(cortina_uart_ports);
> 
> Should not need to free this here, it should be tied to the device, not
> the driver.

Would it be possible to provide a reference to an example 
of a good way to do it.
> 
> 
>> +}
>> +
>> +module_init(cortina_uart_init);
>> +module_exit(cortina_uart_exit);
>> +
>> +MODULE_AUTHOR("Cortina-Access Inc.");
>> +MODULE_DESCRIPTION(" Cortina-Access UART driver");
>> +MODULE_LICENSE("GPL");
>> diff --git a/include/uapi/linux/serial_core.h b/include/uapi/linux/serial_core.h
>> index 62c2204..1931892 100644
>> --- a/include/uapi/linux/serial_core.h
>> +++ b/include/uapi/linux/serial_core.h
>> @@ -277,4 +277,7 @@
>> /* Freescale LINFlexD UART */
>> #define PORT_LINFLEXUART	122
>> 
>> +/* Cortina-Access UART */
>> +#define PORT_CORTINA_ACCESS	123
> 
> Also, no need for this, right?  I would prefer to not add new ids if at
> all possible.

Could you explain why these are no longer required and what has 
been done in the tty design to make this obsolete?
> 
> thanks,
> 
> greg k-h

Re: [PATCH 1/3] tty: serial: Add UART driver for Cortina-Access platform

[Greg Kroah-Hartman]

On Tue, Mar 23, 2021 at 07:25:58PM +0000, Alex Nemirovsky wrote:
> Hi Greg,
> 
> > On Mar 23, 2021, at 2:24 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> > 
> > On Thu, Feb 18, 2021 at 06:42:09PM -0800, Alex Nemirovsky wrote:
> >> +static struct cortina_uart_port *cortina_uart_ports;
> > 
> > Why is this not a per-device pointer?
> > 
> >> +static void __exit cortina_uart_exit(void)
> >> +{
> >> +	platform_driver_unregister(&serial_cortina_driver);
> >> +	uart_unregister_driver(&cortina_uart_driver);
> >> +	kfree(cortina_uart_ports);
> > 
> > Should not need to free this here, it should be tied to the device, not
> > the driver.
> 
> Would it be possible to provide a reference to an example 
> of a good way to do it.

You have a device-specific data structure, put this information there.

> >> +}
> >> +
> >> +module_init(cortina_uart_init);
> >> +module_exit(cortina_uart_exit);
> >> +
> >> +MODULE_AUTHOR("Cortina-Access Inc.");
> >> +MODULE_DESCRIPTION(" Cortina-Access UART driver");
> >> +MODULE_LICENSE("GPL");
> >> diff --git a/include/uapi/linux/serial_core.h b/include/uapi/linux/serial_core.h
> >> index 62c2204..1931892 100644
> >> --- a/include/uapi/linux/serial_core.h
> >> +++ b/include/uapi/linux/serial_core.h
> >> @@ -277,4 +277,7 @@
> >> /* Freescale LINFlexD UART */
> >> #define PORT_LINFLEXUART	122
> >> 
> >> +/* Cortina-Access UART */
> >> +#define PORT_CORTINA_ACCESS	123
> > 
> > Also, no need for this, right?  I would prefer to not add new ids if at
> > all possible.
> 
> Could you explain why these are no longer required and what has 
> been done in the tty design to make this obsolete?

What do you use in userspace that requires this information to be sent
from the kernel?

thanks,

greg k-h

Re: [PATCH 1/3] tty: serial: Add UART driver for Cortina-Access platform

[Greg Kroah-Hartman]

On Wed, Feb 03, 2021 at 11:58:47PM -0800, Alex Nemirovsky wrote:
> From: Jason Li <jason.li@cortina-access.com>
> 
> This driver supports Cortina Access UART IP integrated
> in most all CAXXXX line of SoCs. Earlycom is also supported
> 
> Signed-off-by: Jason Li <jason.li@cortina-access.com>
> Reviewed-by: Alex Nemirovsky <alex.nemirovsky@cortina-access.com>


Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/SubmittingPatches for what needs to be done
  here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

Re: [PATCH 1/3] tty: serial: Add UART driver for Cortina-Access platform

[Greg Kroah-Hartman]

On Wed, Feb 03, 2021 at 11:58:47PM -0800, Alex Nemirovsky wrote:
> +static uintptr_t *cortina_uart_ports;

Note, "uintptr_t" is not a valid kernel type.

Please use a pointer to a real thing, no void pointers please.

thanks,

greg k-h

Re: [PATCH 1/3] tty: serial: Add UART driver for Cortina-Access platform

[Alex Nemirovsky]

Thanks Greg. Will fix this and add a change history.

> On Feb 4, 2021, at 7:49 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> 
> On Wed, Feb 03, 2021 at 11:58:47PM -0800, Alex Nemirovsky wrote:
>> +static uintptr_t *cortina_uart_ports;
> 
> Note, "uintptr_t" is not a valid kernel type.
> 
> Please use a pointer to a real thing, no void pointers please.
> 
> thanks,
> 
> greg k-h