From: Greg KH <greg@kroah.com>
To: "Gong, Sishuai" <sishuai@purdue.edu>
Cc: "jirislaby@kernel.org" <jirislaby@kernel.org>,
"a.darwish@linutronix.de" <a.darwish@linutronix.de>,
"aik@ozlabs.ru" <aik@ozlabs.ru>,
"johan@kernel.org" <johan@kernel.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>
Subject: Re: A data race between tty_port_open() and uart_do_autoconfig()
Date: Wed, 14 Apr 2021 17:08:52 +0200 [thread overview]
Message-ID: <YHcFhJ1EEs9F4As9@kroah.com> (raw)
In-Reply-To: <26D4F25A-5AED-43B0-8527-54A1C1E1F35F@purdue.edu>
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Wed, Apr 14, 2021 at 02:35:24PM +0000, Gong, Sishuai wrote:
> For now we are not sure about if this is a harmful data race or not.
Can you please work to determine that?
> A potential fix could be using the same mutex lock port->mutex instead
> of port->lock, to protect every write on port->count so the reader can
> get a consistent view. However, this seems to be a big change so we
> are wondering it is worthy of this change.
Try it out and see!
thanks,
greg k-h
next prev parent reply other threads:[~2021-04-14 15:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 0:17 A data race between tty_port_open() and uart_do_autoconfig() Gong, Sishuai
2021-04-14 6:20 ` Greg KH
2021-04-14 14:35 ` Gong, Sishuai
2021-04-14 15:08 ` Greg KH [this message]
2021-04-14 16:31 ` Gong, Sishuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHcFhJ1EEs9F4As9@kroah.com \
--to=greg@kroah.com \
--cc=a.darwish@linutronix.de \
--cc=aik@ozlabs.ru \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sishuai@purdue.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox