From: Greg KH <gregkh@linuxfoundation.org>
To: Sherry Sun <sherry.sun@nxp.com>
Cc: jirislaby@kernel.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-imx@nxp.com
Subject: Re: [PATCH 2/2] tty: serial: fsl_lpuart: fix the potential bug of dereference null return value
Date: Mon, 26 Apr 2021 10:09:26 +0200 [thread overview]
Message-ID: <YIZ1NvISshNHtX/Z@kroah.com> (raw)
In-Reply-To: <20210426074935.11131-3-sherry.sun@nxp.com>
On Mon, Apr 26, 2021 at 03:49:35PM +0800, Sherry Sun wrote:
> This issue is reported by Coverity Check.
> In lpuart_probe, return value of function which returns null is
> dereferenced without checking.
>
> Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
> ---
> drivers/tty/serial/fsl_lpuart.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
> index 777d54b593f8..c95e71fd2ca0 100644
> --- a/drivers/tty/serial/fsl_lpuart.c
> +++ b/drivers/tty/serial/fsl_lpuart.c
> @@ -2589,6 +2589,9 @@ static int lpuart_probe(struct platform_device *pdev)
> struct resource *res;
> int ret;
>
> + if (!sdata)
> + return -ENODEV;
How can sdata be NULL?
thanks,
greg k-h
next prev parent reply other threads:[~2021-04-26 8:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-26 7:49 [PATCH 0/2] Fix two coverity issues in fsl_lpuart.c Sherry Sun
2021-04-26 7:49 ` [PATCH 1/2] tty: serial: fsl_lpuart: fix the potential bug of division or modulo by zero Sherry Sun
2021-04-26 8:08 ` Greg KH
2021-04-26 11:30 ` Sherry Sun
2021-04-26 11:34 ` Greg KH
2021-04-26 11:51 ` Sherry Sun
2021-04-26 12:23 ` Greg KH
2021-04-26 12:50 ` Sherry Sun
2021-04-26 7:49 ` [PATCH 2/2] tty: serial: fsl_lpuart: fix the potential bug of dereference null return value Sherry Sun
2021-04-26 8:09 ` Greg KH [this message]
2021-04-26 11:39 ` Sherry Sun
2021-04-26 11:57 ` Fabio Estevam
2021-04-26 12:09 ` Sherry Sun
2021-04-26 12:15 ` Fabio Estevam
2021-04-26 12:48 ` Sherry Sun
2021-04-26 12:22 ` Greg KH
2021-04-26 12:46 ` Sherry Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIZ1NvISshNHtX/Z@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sherry.sun@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox