From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
linux-serial@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] serial: sh-sci: Remove unused STEPFN() macro
Date: Mon, 7 Jun 2021 18:51:54 +0200 [thread overview]
Message-ID: <YL5OqsVMxbHm2EWa@oden.dyn.berto.se> (raw)
In-Reply-To: <970387d104dea5bb7ea674bb89229641467e629b.1623076891.git.geert+renesas@glider.be>
Hi Geert,
Thanks for your patch.
On 2021-06-07 16:43:45 +0200, Geert Uytterhoeven wrote:
> The last user of the STEPFN() macro was removed in commit
> d5cb1319a91d4f13 ("serial: sh-sci: Remove manual break debouncing").
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> drivers/tty/serial/sh-sci.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
> index 4baf1316ea729931..946c4bd920f48960 100644
> --- a/drivers/tty/serial/sh-sci.c
> +++ b/drivers/tty/serial/sh-sci.c
> @@ -840,9 +840,6 @@ static void sci_transmit_chars(struct uart_port *port)
>
> }
>
> -/* On SH3, SCIF may read end-of-break as a space->mark char */
> -#define STEPFN(c) ({int __c = (c); (((__c-1)|(__c)) == -1); })
> -
> static void sci_receive_chars(struct uart_port *port)
> {
> struct tty_port *tport = &port->state->port;
> --
> 2.25.1
>
--
Regards,
Niklas Söderlund
next prev parent reply other threads:[~2021-06-07 16:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 14:43 [PATCH] serial: sh-sci: Remove unused STEPFN() macro Geert Uytterhoeven
2021-06-07 16:51 ` Niklas Söderlund [this message]
2021-06-07 20:31 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YL5OqsVMxbHm2EWa@oden.dyn.berto.se \
--to=niklas.soderlund@ragnatech.se \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).