* [PATCH] serial: sh-sci: Remove unused STEPFN() macro
@ 2021-06-07 14:43 Geert Uytterhoeven
2021-06-07 16:51 ` Niklas Söderlund
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2021-06-07 14:43 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby, Laurent Pinchart
Cc: linux-serial, linux-renesas-soc, Geert Uytterhoeven
The last user of the STEPFN() macro was removed in commit
d5cb1319a91d4f13 ("serial: sh-sci: Remove manual break debouncing").
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/tty/serial/sh-sci.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
index 4baf1316ea729931..946c4bd920f48960 100644
--- a/drivers/tty/serial/sh-sci.c
+++ b/drivers/tty/serial/sh-sci.c
@@ -840,9 +840,6 @@ static void sci_transmit_chars(struct uart_port *port)
}
-/* On SH3, SCIF may read end-of-break as a space->mark char */
-#define STEPFN(c) ({int __c = (c); (((__c-1)|(__c)) == -1); })
-
static void sci_receive_chars(struct uart_port *port)
{
struct tty_port *tport = &port->state->port;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] serial: sh-sci: Remove unused STEPFN() macro
2021-06-07 14:43 [PATCH] serial: sh-sci: Remove unused STEPFN() macro Geert Uytterhoeven
@ 2021-06-07 16:51 ` Niklas Söderlund
2021-06-07 20:31 ` Laurent Pinchart
0 siblings, 1 reply; 3+ messages in thread
From: Niklas Söderlund @ 2021-06-07 16:51 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Greg Kroah-Hartman, Jiri Slaby, Laurent Pinchart, linux-serial,
linux-renesas-soc
Hi Geert,
Thanks for your patch.
On 2021-06-07 16:43:45 +0200, Geert Uytterhoeven wrote:
> The last user of the STEPFN() macro was removed in commit
> d5cb1319a91d4f13 ("serial: sh-sci: Remove manual break debouncing").
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> drivers/tty/serial/sh-sci.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
> index 4baf1316ea729931..946c4bd920f48960 100644
> --- a/drivers/tty/serial/sh-sci.c
> +++ b/drivers/tty/serial/sh-sci.c
> @@ -840,9 +840,6 @@ static void sci_transmit_chars(struct uart_port *port)
>
> }
>
> -/* On SH3, SCIF may read end-of-break as a space->mark char */
> -#define STEPFN(c) ({int __c = (c); (((__c-1)|(__c)) == -1); })
> -
> static void sci_receive_chars(struct uart_port *port)
> {
> struct tty_port *tport = &port->state->port;
> --
> 2.25.1
>
--
Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] serial: sh-sci: Remove unused STEPFN() macro
2021-06-07 16:51 ` Niklas Söderlund
@ 2021-06-07 20:31 ` Laurent Pinchart
0 siblings, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2021-06-07 20:31 UTC (permalink / raw)
To: Niklas Söderlund
Cc: Geert Uytterhoeven, Greg Kroah-Hartman, Jiri Slaby, linux-serial,
linux-renesas-soc
On Mon, Jun 07, 2021 at 06:51:54PM +0200, Niklas Söderlund wrote:
> On 2021-06-07 16:43:45 +0200, Geert Uytterhoeven wrote:
> > The last user of the STEPFN() macro was removed in commit
> > d5cb1319a91d4f13 ("serial: sh-sci: Remove manual break debouncing").
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
A simple and good fix.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> > drivers/tty/serial/sh-sci.c | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
> > index 4baf1316ea729931..946c4bd920f48960 100644
> > --- a/drivers/tty/serial/sh-sci.c
> > +++ b/drivers/tty/serial/sh-sci.c
> > @@ -840,9 +840,6 @@ static void sci_transmit_chars(struct uart_port *port)
> >
> > }
> >
> > -/* On SH3, SCIF may read end-of-break as a space->mark char */
> > -#define STEPFN(c) ({int __c = (c); (((__c-1)|(__c)) == -1); })
> > -
> > static void sci_receive_chars(struct uart_port *port)
> > {
> > struct tty_port *tport = &port->state->port;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-07 20:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-07 14:43 [PATCH] serial: sh-sci: Remove unused STEPFN() macro Geert Uytterhoeven
2021-06-07 16:51 ` Niklas Söderlund
2021-06-07 20:31 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).