From: Greg KH <gregkh@linuxfoundation.org>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: jirislaby@kernel.org, linux-serial@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v3] serial: sh-sci: Stop dmaengine transfer in sci_stop_tx()
Date: Wed, 9 Jun 2021 14:37:14 +0200 [thread overview]
Message-ID: <YMC1+n/w74x33bLX@kroah.com> (raw)
In-Reply-To: <20210609014902.271237-1-yoshihiro.shimoda.uh@renesas.com>
On Wed, Jun 09, 2021 at 10:49:02AM +0900, Yoshihiro Shimoda wrote:
> Stop dmaengine transfer in sci_stop_tx(). Otherwise, the following
> message is possible output when system enters suspend and while
> transferring data, because clearing TIE bit in SCSCR is not able to
> stop any dmaengine transfer.
>
> sh-sci e6550000.serial: ttySC1: Unable to drain transmitter
>
> Note that this patch uses dmaengine_terminate_async() so that
> we can apply this patch into longterm kernel v4.9.x or later.
What should it be using instead of this? Don't worry about older
kernels (you didn't cc: stable@vger.kernel.org so I guess you don't
either), get it right here and then we can deal with backports later.
thanks,
greg k-h
next prev parent reply other threads:[~2021-06-09 12:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 1:49 [PATCH v3] serial: sh-sci: Stop dmaengine transfer in sci_stop_tx() Yoshihiro Shimoda
2021-06-09 12:29 ` Sergei Shtylyov
2021-06-09 15:30 ` Geert Uytterhoeven
2021-06-10 0:50 ` Yoshihiro Shimoda
2021-06-10 6:58 ` Geert Uytterhoeven
2021-06-10 7:01 ` Greg KH
2021-06-10 7:28 ` Yoshihiro Shimoda
2021-06-09 12:37 ` Greg KH [this message]
2021-06-10 0:44 ` Yoshihiro Shimoda
2021-06-09 12:37 ` Greg KH
2021-06-10 0:45 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMC1+n/w74x33bLX@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox