Linux Serial subsystem development
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Moriis Ku <saumah@gmail.com>
Cc: linux-serial@vger.kernel.org, jason_lee@sunix.com,
	taian.chen@sunix.com, morris_ku@sunix.com, edward.lee@sunix.com
Subject: Re: [PATCH] SUNIX SDC serial port driver
Date: Fri, 25 Jun 2021 11:36:24 +0200	[thread overview]
Message-ID: <YNWjmA9nAVhsDO0g@kroah.com> (raw)
In-Reply-To: <20210625092916.12502-1-saumah@gmail.com>

On Fri, Jun 25, 2021 at 05:29:16PM +0800, Moriis Ku wrote:
> From: Morris Ku <saumah@gmail.com>
> 
> Add support for SUNIX SDC serial port
> 
> Cc: Jason Lee <jason_lee@sunix.com>
> Cc: Taian Chen <taian.chen@sunix.com>
> Cc: Morris Ku <morris_ku@sunix.com>
> Cc: Edward Lee <Edward.lee@sunix.com>
> Signed-off-by: Morris Ku <saumah@gmail.com>
> ---
>  Makefile | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Makefile b/Makefile
> index a8bfb65..4dbe94c 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -39,5 +39,7 @@ obj-$(CONFIG_SERIAL_8250_MID)		+= 8250_mid.o
>  obj-$(CONFIG_SERIAL_8250_PXA)		+= 8250_pxa.o
>  obj-$(CONFIG_SERIAL_8250_TEGRA)		+= 8250_tegra.o
>  obj-$(CONFIG_SERIAL_OF_PLATFORM)	+= 8250_of.o
> +obj-$(CONFIG_SERIAL_8250_SDC)		+= 8250_sdc.o
> +obj-$(CONFIG_SERIAL_OF_PLATFORM)	+= 8250_of.o

Why did you add this last line again?

And you sent multiple emails with identical subject lines, yet they did
totally different things.

Please fix up and properly send a patch series that is numbered as is
documented.

thanks,

greg k-h

  reply	other threads:[~2021-06-25  9:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-25  9:29 [PATCH] SUNIX SDC serial port driver Moriis Ku
2021-06-25  9:36 ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-06-25  9:29 Moriis Ku
2021-06-25  9:36 ` Greg KH
2021-06-25  9:30 Moriis Ku
2021-06-25  9:37 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YNWjmA9nAVhsDO0g@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=edward.lee@sunix.com \
    --cc=jason_lee@sunix.com \
    --cc=linux-serial@vger.kernel.org \
    --cc=morris_ku@sunix.com \
    --cc=saumah@gmail.com \
    --cc=taian.chen@sunix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox