Re: [PATCH 3/8] dt-bindings: serial: fsl-linflexuart: Add compatible for S32G2

Rob Herring
2021-08-13T18:09:20Z

On Thu, Aug 05, 2021 at 02:54:24PM +0800, Chester Lin wrote:
> Add a compatible string for the uart binding of NXP S32G2 platforms. Here
> we use "s32v234-linflexuart" as fallback since the current linflexuart
> driver still works on S32G2.
>
> Signed-off-by: Chester Lin <clin@suse.com>
> ---
> .../bindings/serial/fsl,s32-linflexuart.yaml | 26 ++++++++++++++++---
> 1 file changed, 22 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.yaml b/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.yaml
> index acfe34706ccb..e731f3f6cea4 100644
> --- a/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.yaml
> +++ b/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.yaml
> @@ -21,10 +21,20 @@ allOf:
>
> properties:
> compatible:
> - description: The LINFlexD controller on S32V234 SoC, which can be
> - configured in UART mode.
> - items:
> - - const: fsl,s32v234-linflexuart
> + minItems: 1
> + maxItems: 2

minItems/maxItems not needed here.

> + oneOf:
> + - description: The LINFlexD controller on S32G2 SoC, which can be
> + configured in UART mode.
> + items:
> + - enum:
> + - fsl,s32g2-linflexuart
> + - const: fsl,s32v234-linflexuart
> +
> + - description: The LINFlexD controller on S32V234 SoC, which can be
> + configured in UART mode.
> + items:
> + - const: fsl,s32v234-linflexuart
>
> reg:
> maxItems: 1
> @@ -41,8 +51,16 @@ unevaluatedProperties: false
>
> examples:
> - |
> + /* S32V234 */
> serial@40053000 {
> compatible = "fsl,s32v234-linflexuart";
> reg = <0x40053000 0x1000>;
> interrupts = <0 59 4>;
> };
> +
> + /* S32G2 */
> + serial@401c8000 {
> + compatible = "fsl,s32g2-linflexuart", "fsl,s32v234-linflexuart";
> + reg = <0x401c8000 0x3000>;
> + interrupts = <0 82 1>;
> + };

This doesn't really warrant another example just for a new compatible
string.