Re: [PATCH 2/8] dt-bindings: serial: fsl-linflexuart: convert to json-schema format

Chester Lin
2021-08-13T11:11:25Z

Hi Andreas,

On Thu, Aug 12, 2021 at 06:04:44PM +0200, Andreas Färber wrote:
> On 05.08.21 08:54, Chester Lin wrote:
> > Convert the FSL LINFlexD UART binding to json-schema.
> >
> > Signed-off-by: Chester Lin <clin@suse.com>
> > ---
> > .../bindings/serial/fsl,s32-linflexuart.txt | 22 ---------
> > .../bindings/serial/fsl,s32-linflexuart.yaml | 48 +++++++++++++++++++
> > 2 files changed, 48 insertions(+), 22 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.txt
> > create mode 100644 Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.yaml
>
> Thanks for your effort, Chester.
>
> > diff --git a/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.txt b/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.txt
> > deleted file mode 100644
> > index f1bbe0826be5..000000000000
> > --- a/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.txt
> > +++ /dev/null
> > @@ -1,22 +0,0 @@
> > -* Freescale LINFlexD UART
> > -
> > -The LINFlexD controller implements several LIN protocol versions, as well as
> > -support for full-duplex UART communication through 8-bit and 9-bit frames.
> > -
> > -See chapter 47 ("LINFlexD") in the reference manual[1].
> > -
> > -Required properties:
> > -- compatible :
> > - - "fsl,s32v234-linflexuart" for LINFlexD configured in UART mode, which
> > - is compatible with the one integrated on S32V234 SoC
> > -- reg : Address and length of the register set for the device
> > -- interrupts : Should contain uart interrupt
> > -
> > -Example:
> > -uart0: serial@40053000 {
> > - compatible = "fsl,s32v234-linflexuart";
> > - reg = <0x0 0x40053000 0x0 0x1000>;
> > - interrupts = <0 59 4>;
> > -};
> > -
> > -[1] https://www.nxp.com/webapp/Download?colCode=S32V234RM
> > diff --git a/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.yaml b/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.yaml
> > new file mode 100644
> > index 000000000000..acfe34706ccb
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.yaml
> > @@ -0,0 +1,48 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>
> Since this is dual-licensed and BSD-2-Clause would seem compatible with
> GPLv3, this could probably be s/GPL-2.0-only/GPL-2.0-or-later/ ? Not a
> blocker.

There's no license identifier in the original file so it's not a problem to
choose "GPL-2.0-or-later".

>
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/serial/fsl,s32-linflexuart.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Freescale LINFlexD UART
> > +
> > +description: |
> > + The LINFlexD controller implements several LIN protocol versions, as well
> > + as support for full-duplex UART communication through 8-bit and 9-bit
> > + frames. See chapter 47 ("LINFlexD") in the reference manual
> > + https://www.nxp.com/webapp/Download?colCode=S32V234RM.
> > +
> > +maintainers:
> > + - Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > + - Rob Herring <robh@kernel.org>
>
> @Shawn: I assume we need both of them to ack this (or an S32V maintainer
> to volunteer), since they were not named in the .txt file before?
>
> > +
> > +allOf:
> > + - $ref: "serial.yaml"
> > +
> > +properties:
> > + compatible:
> > + description: The LINFlexD controller on S32V234 SoC, which can be
> > + configured in UART mode.
> > + items:
> > + - const: fsl,s32v234-linflexuart
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - interrupts
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > + - |
> > + serial@40053000 {
> > + compatible = "fsl,s32v234-linflexuart";
> > + reg = <0x40053000 0x1000>;
> > + interrupts = <0 59 4>;
> > + };
>
> Otherwise looking sane,
>
> Reviewed-by: Andreas Färber <afaerber@suse.de>
>
> Thanks,
> Andreas
>
> --
> SUSE Software Solutions Germany GmbH
> Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Felix Imendörffer
> HRB 36809 (AG Nürnberg)
>