From: Johan Hovold <johan@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: "Fabio Estevam" <festevam@denx.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Michael Walle" <michael@walle.cc>,
linux-serial@vger.kernel.org, "Marek Vasut" <marex@denx.de>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH v2] serial: imx: Fix sysrq deadlock
Date: Fri, 1 Oct 2021 15:48:45 +0200 [thread overview]
Message-ID: <YVcRvYDqLWZ4liVl@hovoldconsulting.com> (raw)
In-Reply-To: <CAOMZO5BD95rpU-ChZp591JnnYbGFUZuUdTVxwDNsMUObWVmA_A@mail.gmail.com>
On Fri, Oct 01, 2021 at 07:17:53AM -0300, Fabio Estevam wrote:
> Hi Johan,
>
> On Fri, Oct 1, 2021 at 4:53 AM Johan Hovold <johan@kernel.org> wrote:
>
> > Why did you drop the cast? If there's anything in the high bits you'd
> > see the help text printed as you report below (even if it seems
> > unlikely).
>
> That was it, thanks!
>
> I have taken your feedback into consideration and sent a v3.
>
> The only one that I didn't do was to reorganize the code to avoid the
> unlock/lock as
> this would require a significant rework.
Judging from a quick look at the code is very straight-forward, and we
don't want to add interrupt latency just to shut up lockdep.
Johan
prev parent reply other threads:[~2021-10-01 13:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 21:43 [PATCH v2] serial: imx: Fix sysrq deadlock Fabio Estevam
2021-09-30 7:02 ` Uwe Kleine-König
2021-09-30 7:54 ` Johan Hovold
2021-09-30 13:45 ` Fabio Estevam
2021-10-01 7:52 ` Johan Hovold
2021-10-01 10:17 ` Fabio Estevam
2021-10-01 13:48 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVcRvYDqLWZ4liVl@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=festevam@denx.de \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-serial@vger.kernel.org \
--cc=marex@denx.de \
--cc=michael@walle.cc \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox