From: Johan Hovold <johan@kernel.org>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: gregkh@linuxfoundation.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 16/16] tty: drop tty_flip_buffer_push
Date: Thu, 18 Nov 2021 09:10:54 +0100 [thread overview]
Message-ID: <YZYKjmejIqub5tTf@hovoldconsulting.com> (raw)
In-Reply-To: <01079c75-2d2f-fe57-db0e-6aadf9963846@kernel.org>
On Thu, Nov 18, 2021 at 08:54:05AM +0100, Jiri Slaby wrote:
> Friendly ping Johan, Greg: any opinions on the tty_schedule_flip vs
> tty_flip_buffer_push case -- which one should I keep?
I still prefer keeping tty_flip_buffer_push() since it's name is much
more descriptive and since it's used by almost all drivers.
There's also no good reason to force developers to relearn the insert +
push pattern either (and rewriting the documentation and books that
describe it).
Johan
> On 22. 09. 21, 8:57, Jiri Slaby wrote:
> > On 16. 09. 21, 12:03, Johan Hovold wrote:
> >> On Tue, Sep 14, 2021 at 11:14:15AM +0200, Jiri Slaby wrote:
> >>> Since commit a9c3f68f3cd8d (tty: Fix low_latency BUG) in 2014,
> >>> tty_flip_buffer_push() is only a wrapper to tty_schedule_flip(). All
> >>> users were converted, so remove tty_flip_buffer_push() completely.
> >>
> >> Did you consider inlining tty_flip_buffer_push() or unexporting
> >> tty_schedule_flip() instead?
> >
> > Yes -- I see no reason for two functions doing the very same thing. It's
> > only confusing.
> >
> >> The name tty_flip_buffer_push() is arguable more descriptive since the
> >> work may already be running and is also less tied to the implementation.
> >>
> >> The ratio of drivers using tty_flip_buffer_push() over
> >> tty_schedule_flip() is also something like 186 to 15 so that would
> >> amount to a lot less churn too.
> >
> > OK, I can do either way. I chose this path as tty_schedule_flip was a
> > wrapper to tty_flip_buffer_push. In any case, I wouldn't take the number
> > of changed drivers as a measure. But if it makes more sense for people
> > regarding the naming, I will "flip" the two flips.
next prev parent reply other threads:[~2021-11-18 8:11 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 9:11 [PATCH 01/16] tty: unexport tty_ldisc_release Jiri Slaby
2021-09-14 9:11 ` [PATCH 02/16] tty: remove flags from struct tty_ldisc_ops Jiri Slaby
2021-09-14 9:11 ` [PATCH 03/16] tty: remove extern from functions in tty headers Jiri Slaby
2021-09-14 9:11 ` [PATCH 04/16] tty: make tty_ldisc_ops::hangup return void Jiri Slaby
2021-09-15 8:05 ` Marc Kleine-Budde
2021-09-15 11:48 ` Mark Brown
2021-09-21 3:59 ` Dmitry Torokhov
2021-09-14 9:11 ` [PATCH 05/16] tty: remove file from tty_mode_ioctl Jiri Slaby
2021-09-15 8:05 ` Marc Kleine-Budde
2021-09-14 9:11 ` [PATCH 06/16] tty: remove file from n_tty_ioctl_helper Jiri Slaby
2021-09-14 9:15 ` Krzysztof Kozlowski
2021-09-14 9:11 ` [PATCH 07/16] tty: remove file from tty_ldisc_ops::ioctl and compat_ioctl Jiri Slaby
2021-09-14 9:16 ` Krzysztof Kozlowski
2021-09-15 8:02 ` Marc Kleine-Budde
2021-09-21 4:00 ` Dmitry Torokhov
2021-09-21 10:52 ` Jiri Slaby
2021-09-21 11:36 ` Greg KH
2021-09-21 15:51 ` Jiri Slaby
2021-09-22 15:01 ` Greg KH
2021-09-14 9:14 ` [PATCH 08/16] tty: drivers/tty/serial/, stop using tty_flip_buffer_push Jiri Slaby
2021-09-14 9:14 ` [PATCH 09/16] tty: drivers/tty/, " Jiri Slaby
2021-09-14 16:06 ` David Sterba
2021-09-14 9:14 ` [PATCH 10/16] tty: drivers/usb/serial/, " Jiri Slaby
2021-09-14 9:14 ` [PATCH 11/16] tty: drivers/usb/, " Jiri Slaby
2021-09-14 9:14 ` [PATCH 12/16] tty: arch/, " Jiri Slaby
2021-09-15 8:10 ` Max Filippov
2021-09-14 9:14 ` [PATCH 13/16] tty: drivers/s390/char/, " Jiri Slaby
2021-09-14 9:14 ` [PATCH 14/16] tty: drivers/staging/, " Jiri Slaby
2021-09-14 13:19 ` [greybus-dev] " Alex Elder
2021-09-14 9:14 ` [PATCH 15/16] tty: the rest, " Jiri Slaby
2021-09-14 11:58 ` Samuel Iglesias Gonsálvez
2021-09-14 9:14 ` [PATCH 16/16] tty: drop tty_flip_buffer_push Jiri Slaby
2021-09-16 10:03 ` Johan Hovold
2021-09-22 6:57 ` Jiri Slaby
2021-09-23 8:32 ` Johan Hovold
2021-11-18 7:54 ` Jiri Slaby
2021-11-18 8:10 ` Johan Hovold [this message]
2021-09-14 9:17 ` [PATCH 08/16] tty: drivers/tty/serial/, stop using tty_flip_buffer_push Krzysztof Kozlowski
2021-09-14 12:54 ` Uwe Kleine-König
2021-09-14 13:53 ` Richard Genoud
2021-09-15 17:00 ` Tobias Klauser
2021-09-15 17:53 ` Andreas Färber
2021-09-15 23:43 ` Andrew Jeffery
2021-09-16 7:13 ` Nicolas Ferre
2021-09-16 7:32 ` Chunyan Zhang
2021-09-16 7:48 ` Neil Armstrong
2021-09-16 12:54 ` Russell King (Oracle)
2021-09-16 20:30 ` Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZYKjmejIqub5tTf@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).