From: Stafford Horne <shorne@gmail.com>
To: Alyssa Ross <hi@alyssa.is>
Cc: Karol Gugala <kgugala@antmicro.com>,
Mateusz Holenko <mholenko@antmicro.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Filip Kokosinski <fkokosinski@antmicro.com>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] serial: liteuart: fix MODULE_ALIAS
Date: Sun, 16 Jan 2022 17:35:56 +0900 [thread overview]
Message-ID: <YePY7EO5iLmbhh3R@antec> (raw)
In-Reply-To: <20220104131030.1674733-1-hi@alyssa.is>
On Tue, Jan 04, 2022 at 01:10:28PM +0000, Alyssa Ross wrote:
> modprobe can't handle spaces in aliases.
>
> Fixes: 1da81e5562fa ("drivers/tty/serial: add LiteUART driver")
> Signed-off-by: Alyssa Ross <hi@alyssa.is>
> ---
> drivers/tty/serial/liteuart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/liteuart.c b/drivers/tty/serial/liteuart.c
> index 2941659e5274..7f74bf7bdcff 100644
> --- a/drivers/tty/serial/liteuart.c
> +++ b/drivers/tty/serial/liteuart.c
> @@ -436,4 +436,4 @@ module_exit(liteuart_exit);
> MODULE_AUTHOR("Antmicro <www.antmicro.com>");
> MODULE_DESCRIPTION("LiteUART serial driver");
> MODULE_LICENSE("GPL v2");
> -MODULE_ALIAS("platform: liteuart");
> +MODULE_ALIAS("platform:liteuart");
This looks fine to me.
Acked-by: Stafford Horne <shorne@gmail.com>
> base-commit: c9e6606c7fe92b50a02ce51dda82586ebdf99b48
> --
> 2.33.0
>
prev parent reply other threads:[~2022-01-16 8:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 13:10 [PATCH] serial: liteuart: fix MODULE_ALIAS Alyssa Ross
2022-01-16 8:35 ` Stafford Horne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YePY7EO5iLmbhh3R@antec \
--to=shorne@gmail.com \
--cc=fkokosinski@antmicro.com \
--cc=gregkh@linuxfoundation.org \
--cc=hi@alyssa.is \
--cc=jirislaby@kernel.org \
--cc=kgugala@antmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mholenko@antmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).