From: Greg KH <gregkh@linuxfoundation.org>
To: Hammer Hsieh <hammerh0314@gmail.com>
Cc: robh+dt@kernel.org, linux-serial@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
jirislaby@kernel.org, p.zabel@pengutronix.de,
wells.lu@sunplus.com, hammer.hsieh@sunplus.com
Subject: Re: [PATCH v7 2/2] serial:sunplus-uart:Add Sunplus SoC UART Driver
Date: Mon, 7 Feb 2022 08:18:26 +0100 [thread overview]
Message-ID: <YgDHwgg0s6U3bFxF@kroah.com> (raw)
In-Reply-To: <1644213481-20321-3-git-send-email-hammerh0314@gmail.com>
On Mon, Feb 07, 2022 at 01:58:01PM +0800, Hammer Hsieh wrote:
> Add Sunplus SoC UART Driver
>
We need more of a changelog comment here please. Describe the hardware,
what the new tty name you are using, and other stuff. Be descriptive.
> --- a/include/uapi/linux/serial_core.h
> +++ b/include/uapi/linux/serial_core.h
> @@ -274,4 +274,7 @@
> /* Freescale LINFlexD UART */
> #define PORT_LINFLEXUART 122
>
> +/* Sunplus UART */
> +#define PORT_SUNPLUS 123
Why is this needed? Are you going to require this in some userspace
code? If not, please do not add it.
thanks,
greg k-h
next prev parent reply other threads:[~2022-02-07 7:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 5:57 [PATCH v7 0/2] Add UART driver for Suplus SP7021 SoC Hammer Hsieh
2022-02-07 5:58 ` [PATCH v7 1/2] dt-bindings:serial:Add bindings doc for Sunplus SoC UART Driver Hammer Hsieh
2022-02-07 5:58 ` [PATCH v7 2/2] serial:sunplus-uart:Add " Hammer Hsieh
2022-02-07 7:18 ` Greg KH [this message]
2022-02-07 11:28 ` hammer hsieh
2022-02-08 6:27 ` Jiri Slaby
2022-02-08 11:16 ` hammer hsieh
2022-02-08 11:31 ` Greg KH
2022-02-09 10:53 ` hammer hsieh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgDHwgg0s6U3bFxF@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devicetree@vger.kernel.org \
--cc=hammer.hsieh@sunplus.com \
--cc=hammerh0314@gmail.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=wells.lu@sunplus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).