From: Greg KH <gregkh@linuxfoundation.org>
To: Kumaravel.Thiagarajan@microchip.com
Cc: linux-serial@vger.kernel.org, Sundararaman.H@microchip.com,
Ronnie.Kunin@microchip.com, Tharunkumar.Pasumarthi@microchip.com,
Annirudh.D@microchip.com, Pragash.Mangalapandian@microchip.com
Subject: Re: Reg: Serial port driver for microchip's new PCIe UART device
Date: Wed, 9 Feb 2022 12:30:49 +0100 [thread overview]
Message-ID: <YgOl6SFsKnZxkbFy@kroah.com> (raw)
In-Reply-To: <CH0PR11MB538034CCE6C1868DB7BD8127E92E9@CH0PR11MB5380.namprd11.prod.outlook.com>
On Wed, Feb 09, 2022 at 10:38:34AM +0000, Kumaravel.Thiagarajan@microchip.com wrote:
> Dear Greg KH,
>
> I am Kumaravel Thiagarajan from Microchip India.
>
> We are working on a PCIe based multi-instance UART device.
> Based on the Linux community feedback few months back, we had written it as a custom driver inside drivers/tty/serial/8250.
> Now this custom driver is requiring a DWORD FIFO access for both Tx and Rx, and I am in the process of changing my driver code.
Why does the hardware not follow the normal standard here?
And are you sure it will still not fit into the 8250 format?
> Can I model my custom driver on serial drivers present in drivers/tty/serial/ directory?
You could, but it would be much smaller and easier to use the 8250
framework given that you probably do have an 8250-like device, right?
> I am implementing my functions for uart_ops structure and the necessary ISR in a separate file mchp_pci1xxxx_uart.c inside the drivers/tty/serial/ directory.
>
> I wish this custom UART driver to get through Linux community submission.
> Do you see any risk in this approach? Do you have any suggestions?
Let's see the code before we can give you any firm answers.
good luck!
greg k-h
next prev parent reply other threads:[~2022-02-09 12:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 10:38 Reg: Serial port driver for microchip's new PCIe UART device Kumaravel.Thiagarajan
2022-02-09 11:30 ` Greg KH [this message]
2022-02-10 10:38 ` Kumaravel.Thiagarajan
2022-02-11 12:02 ` Greg KH
2022-02-14 12:51 ` Kumaravel.Thiagarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgOl6SFsKnZxkbFy@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Annirudh.D@microchip.com \
--cc=Kumaravel.Thiagarajan@microchip.com \
--cc=Pragash.Mangalapandian@microchip.com \
--cc=Ronnie.Kunin@microchip.com \
--cc=Sundararaman.H@microchip.com \
--cc=Tharunkumar.Pasumarthi@microchip.com \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).