From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: Qing Wang <wangqing@vivo.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty: serial: 8250: add missing pci_dev_put() before return
Date: Tue, 15 Feb 2022 11:54:49 +0200 [thread overview]
Message-ID: <Ygt4aUMVKM8ZcW/5@smile.fi.intel.com> (raw)
In-Reply-To: <621e2079-567c-6954-9744-c51748dd48dd@kernel.org>
On Tue, Feb 15, 2022 at 07:02:57AM +0100, Jiri Slaby wrote:
> On 15. 02. 22, 6:55, Jiri Slaby wrote:
> > On 15. 02. 22, 3:00, Qing Wang wrote:
> > > From: Wang Qing <wangqing@vivo.com>
> > >
> > > pci_get_slot() increases its reference count, the caller must
> > > decrement the reference count by calling pci_dev_put()
Wang, thank you for the report!
...
> > What about the "return -ENODEV" few lines above?
>
> On the top of that, the code stores the pointer to the dev:
> param->dma_dev = &dma_dev->dev;
>
> So we should likely put the device in ->exit(), not ->setup().
I think I may fix all these and send a new version.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-02-15 9:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 2:00 [PATCH] tty: serial: 8250: add missing pci_dev_put() before return Qing Wang
2022-02-15 5:55 ` Jiri Slaby
2022-02-15 6:02 ` Jiri Slaby
2022-02-15 9:54 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ygt4aUMVKM8ZcW/5@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=wangqing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox