From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1005C433F5 for ; Tue, 15 Feb 2022 12:27:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234711AbiBOM2B (ORCPT ); Tue, 15 Feb 2022 07:28:01 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:36358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233510AbiBOM2A (ORCPT ); Tue, 15 Feb 2022 07:28:00 -0500 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53CE6107AAB; Tue, 15 Feb 2022 04:27:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644928071; x=1676464071; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=RhsArYRmWUjv92mfHTpn/hhqqJT+C/mxoD6qW8AsTjY=; b=NnmExAp85fcoz3nWkxxrax8gTGyeKjkWu44qgPliw9Jz7xiNDLT6te9o TV4JdQeu98M7vgP8HhyZxuWSph2CmeZdUnSs4RrS560XWKdeEw2yvZveo 9mG94Byzlp5zlxyOa6NOhFcj8z3OxU9IhlI8OSYF5rgCjubsVBRHM2sIE nZrGH/MRJMBshqrzBVrUb0r7NPI+wtVQUKfx/q6UaRpeY22J1km6Ol2v4 T1yP15S3r+ks63LynMp1RVXXlFbhSQ+Zuy3vARLDOtcWZuAyyuut6Jt5q 4z5RfK87ylxpkcmebE6IaJdEcr+JzGjkW3sw5PzYKXLL8sVzCHtrAoVes A==; X-IronPort-AV: E=McAfee;i="6200,9189,10258"; a="311077686" X-IronPort-AV: E=Sophos;i="5.88,370,1635231600"; d="scan'208";a="311077686" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2022 04:27:50 -0800 X-IronPort-AV: E=Sophos;i="5.88,370,1635231600"; d="scan'208";a="773496380" Received: from smile.fi.intel.com ([10.237.72.59]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2022 04:27:49 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nJwv0-004ur5-K3; Tue, 15 Feb 2022 14:26:54 +0200 Date: Tue, 15 Feb 2022 14:26:54 +0200 From: Andy Shevchenko To: Jiri Slaby Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Qing Wang Subject: Re: [PATCH v1 1/1] serial: 8250_mid: Balance reference count for PCI DMA device Message-ID: References: <20220215100920.41984-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Tue, Feb 15, 2022 at 02:25:42PM +0200, Andy Shevchenko wrote: > On Tue, Feb 15, 2022 at 12:08:26PM +0100, Jiri Slaby wrote: > > On 15. 02. 22, 11:31, Andy Shevchenko wrote: ... > > No, I mixed up patches :P. This was meant as a comment to > > "serial: 8250_lpss: Balance reference count for PCI DMA device" > > > > byt_serial_exit() isn't called when byt_serial_setup() fails with EINVAL if > > I'm looking correctly. > > I see now, thanks for catching this! > I will send a v2 soon. What do you think about this patch? Can you give your tag if the code is looking good? -- With Best Regards, Andy Shevchenko