Re: [tty:tty-testing 31/42] drivers/mmc/core/sdio_uart.c:253:16: error: implicit declaration of function 'UART_LCR_WLEN'; did you mean 'UART_LCR_WLEN5'?

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Mon, Feb 28, 2022 at 05:36:53AM +0100, Jiri Slaby wrote:
> On 25. 02. 22, 19:34, kernel test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
> > head:   a6d8f09319fff9e6e7a91cadb19923b8cb2573e0
> > commit: b6f8eaea0cf1afe2500f8af7b6cc805647fe4889 [31/42] sdio_uart: make use of UART_LCR_WLEN() + tty_get_char_size()
> > config: arc-randconfig-r043-20220225 (https://download.01.org/0day-ci/archive/20220226/202202260105.p77piygB-lkp@intel.com/config)
> > compiler: arceb-elf-gcc (GCC) 11.2.0
> > reproduce (this is a W=1 build):
> >          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >          chmod +x ~/bin/make.cross
> >          # https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git/commit/?id=b6f8eaea0cf1afe2500f8af7b6cc805647fe4889
> >          git remote add tty https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
> >          git fetch --no-tags tty tty-testing
> >          git checkout b6f8eaea0cf1afe2500f8af7b6cc805647fe4889
> >          # save the config file to linux build tree
> >          mkdir build_dir
> >          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash
> > 
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> > 
> > All errors (new ones prefixed by >>):
> > 
> >     drivers/mmc/core/sdio_uart.c: In function 'sdio_uart_change_speed':
> > > > drivers/mmc/core/sdio_uart.c:253:16: error: implicit declaration of function 'UART_LCR_WLEN'; did you mean 'UART_LCR_WLEN5'? [-Werror=implicit-function-declaration]
> >       253 |         cval = UART_LCR_WLEN(tty_get_char_size(termios->c_cflag));
> >           |                ^~~~~~~~~~~~~
> >           |                UART_LCR_WLEN5
> >     cc1: some warnings being treated as errors
> > 
> > 
> > vim +253 drivers/mmc/core/sdio_uart.c
> 
> This is caused by the move to serial.h. Apart from sdio_uart, these drivers
> do not include serial.h directly (but apart from sdio_uart are able to
> compile, i.e. include it via some chain):
> drivers/tty/serial/8250/8250_omap.c
> drivers/tty/serial/jsm/jsm_neo.c
> drivers/tty/serial/omap-serial.c
> drivers/tty/serial/pxa.c

Yes, this is my fault, I'll fix this up later today, thanks.

greg k-h