From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7DC0C433EF for ; Thu, 10 Mar 2022 18:03:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234616AbiCJSEh (ORCPT ); Thu, 10 Mar 2022 13:04:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239223AbiCJSEg (ORCPT ); Thu, 10 Mar 2022 13:04:36 -0500 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D23D14076D; Thu, 10 Mar 2022 10:03:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646935415; x=1678471415; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=USeMBfA1GZknJ/QfufCF/Woi1F8tPQcpUrNiIKEwmrc=; b=baVETSrXUhX8/NM7cEAHByv1XBtl/dzx204436aVeWSFPlq9dvY96spD vO9AwT6/L35Hn6YWp41iCSwQMuOHLiCSVud7rbFG8ijXIhPsO2y5sKpno 4RJBBI2KIB2vfJZQXVcgEmQ0/8DHNjlOKAfzK0TtWtDADr8YJuCEPpAXV jxq/KK9Lg1iwC/HonXQYqCev9nrEDURtiKikrud8IY1nGBnnOurobiK9M TlixVQZwcy1dFS38oTHgNV1NIIyeYeqOaUinF+hoAIy4qUbHcXaPZm0yo rR+5puEtY0vWoNz7mFuaL4W4Kbqu3gk1To7a9thulMxmSOGZZrYkkESkW g==; X-IronPort-AV: E=McAfee;i="6200,9189,10282"; a="252890761" X-IronPort-AV: E=Sophos;i="5.90,171,1643702400"; d="scan'208";a="252890761" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Mar 2022 10:03:28 -0800 X-IronPort-AV: E=Sophos;i="5.90,171,1643702400"; d="scan'208";a="578889041" Received: from smile.fi.intel.com ([10.237.72.59]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Mar 2022 10:03:24 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nSN7Z-00ErPp-PU; Thu, 10 Mar 2022 20:02:41 +0200 Date: Thu, 10 Mar 2022 20:02:41 +0200 From: Andy Shevchenko To: Miquel Raynal Cc: linux-renesas-soc@vger.kernel.org, Magnus Damm , Gareth Williams , Phil Edworthy , Geert Uytterhoeven , Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org, Milan Stevanovic , Jimmy Lalande , Pascal Eberhard , Thomas Petazzoni , Herve Codina , Clement Leger Subject: Re: [PATCH 3/7] serial: 8250_dw: Use a fallback CPR value if not synthesized Message-ID: References: <20220310161650.289387-1-miquel.raynal@bootlin.com> <20220310161650.289387-4-miquel.raynal@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220310161650.289387-4-miquel.raynal@bootlin.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Thu, Mar 10, 2022 at 05:16:46PM +0100, Miquel Raynal wrote: > From: Phil Edworthy > > This UART controller can be synthesized without the CPR register. > In that case, let's use the platform information to provide a CPR value. ... > +#include > + const struct dw8250_platform_data *plat = of_device_get_match_data(up->port.dev); No. Please use device property APIs. -- With Best Regards, Andy Shevchenko