From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6703C433EF for ; Tue, 29 Mar 2022 15:51:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239006AbiC2Pxd (ORCPT ); Tue, 29 Mar 2022 11:53:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238845AbiC2Pxc (ORCPT ); Tue, 29 Mar 2022 11:53:32 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 782FD14DFEE; Tue, 29 Mar 2022 08:51:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648569109; x=1680105109; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=GMfvqPfppBDRudk8mHfrFDRT2z+zS3rqXq/teqPq+08=; b=H3p5Euh9Zp+aeChXSVEWTXe0GKALzKmLCj6soOkIBg18yguoHVPcJdRk nymZCXljmnixYhH1QS93d4owReFOBLWlKqwT8byQTugHzZ5anGSDHRC+p vxIfyRoNrS0Is7u+KRya21RAGFkq/VIyga9Qm8iVk8Pon5wE1ZZMAM04D 1HJJoXLkOIdqeZSF38tPjq5lRceUe3Kst9r6RaXyi05u64WplNSBFnZYZ XaZjJ5FNDehoxk3EmTFdrvI/r0lCyvoM8hA/It20tHmPgKKFo3TmmuaMq 6rI+SvkIsDyuBgJlH/aWuv0NRSvY6eCHoItR15EN/J/cK8p1tkkP9y7GU A==; X-IronPort-AV: E=McAfee;i="6200,9189,10301"; a="256859157" X-IronPort-AV: E=Sophos;i="5.90,220,1643702400"; d="scan'208";a="256859157" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2022 08:51:48 -0700 X-IronPort-AV: E=Sophos;i="5.90,220,1643702400"; d="scan'208";a="585623469" Received: from smile.fi.intel.com ([10.237.72.59]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2022 08:51:44 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nZE7i-008qA2-TB; Tue, 29 Mar 2022 18:51:10 +0300 Date: Tue, 29 Mar 2022 18:51:10 +0300 From: Andy Shevchenko To: Miquel Raynal Cc: Geert Uytterhoeven , Magnus Damm , Greg Kroah-Hartman , Jiri Slaby , linux-renesas-soc@vger.kernel.org, linux-serial@vger.kernel.org, Milan Stevanovic , Jimmy Lalande , Pascal Eberhard , Thomas Petazzoni , Herve Codina , Clement Leger , Emil Renner Berthing Subject: Re: [PATCH v3 04/10] serial: 8250: dw: Create a more generic platform data structure Message-ID: References: <20220329152430.756947-1-miquel.raynal@bootlin.com> <20220329152430.756947-5-miquel.raynal@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220329152430.756947-5-miquel.raynal@bootlin.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Tue, Mar 29, 2022 at 05:24:24PM +0200, Miquel Raynal wrote: > Before adding more platform data information, let's turn the quirks > information as being a member of a wider structure. More fields will be > added later. > struct device_node *np = p->dev->of_node; > - unsigned int quirks = (unsigned int)device_get_match_data(p->dev); > + const struct dw8250_platform_data *pdata = device_get_match_data(p->dev); > + unsigned int quirks = pdata ? pdata->quirks : 0; I remember Greg is not fan of ternary operators. Taking into account my suggestion in the next patch, I think this can simply become unsigned int quirks = data->pdata.quirks; -- With Best Regards, Andy Shevchenko