From: Tony Lindgren <tony@atomide.com>
To: Johan Hovold <johan@kernel.org>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Andy Shevchenko" <andriy.shevchenko@intel.com>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
linux-serial@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Steffen Trumtrar" <s.trumtrar@pengutronix.de>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Matwey V. Kornilov" <matwey@sai.msu.ru>
Subject: Re: [PATCH 2/2] serial: 8250: Fix runtime PM for start_tx() for empty buffer
Date: Mon, 11 Apr 2022 13:33:34 +0300 [thread overview]
Message-ID: <YlQD/gvwYp+cJxX9@atomide.com> (raw)
In-Reply-To: <YlP/P/JeZ/fS1zAK@hovoldconsulting.com>
* Johan Hovold <johan@kernel.org> [220411 10:10]:
> On Mon, Apr 11, 2022 at 12:48:05PM +0300, Tony Lindgren wrote:
> > diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c
> > --- a/drivers/tty/serial/8250/8250_port.c
> > +++ b/drivers/tty/serial/8250/8250_port.c
> > @@ -1677,8 +1677,10 @@ static void serial8250_start_tx(struct uart_port *port)
> >
> > serial8250_rpm_get_tx(up);
> >
> > - if (!port->x_char && uart_circ_empty(&port->state->xmit))
> > + if (!port->x_char && uart_circ_empty(&port->state->xmit)) {
> > + serial8250_rpm_put_tx(up);
> > return;
> > + }
>
> Move this before the runtime pm get instead?
Yup good idea.
Tony
next prev parent reply other threads:[~2022-04-11 10:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 9:48 [PATCH 1/2] serial: 8250: Fix runtime PM for start_tx() for RS485 Tony Lindgren
2022-04-11 9:48 ` [PATCH 2/2] serial: 8250: Fix runtime PM for start_tx() for empty buffer Tony Lindgren
2022-04-11 10:02 ` Uwe Kleine-König
2022-04-11 10:12 ` Tony Lindgren
2022-04-11 10:13 ` Johan Hovold
2022-04-11 10:33 ` Tony Lindgren [this message]
2022-04-11 9:57 ` [PATCH 1/2] serial: 8250: Fix runtime PM for start_tx() for RS485 Johan Hovold
2022-04-11 10:10 ` Tony Lindgren
2022-04-11 10:25 ` Johan Hovold
2022-04-11 10:32 ` Tony Lindgren
2022-04-11 11:56 ` Johan Hovold
2022-04-11 12:01 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlQD/gvwYp+cJxX9@atomide.com \
--to=tony@atomide.com \
--cc=andriy.shevchenko@intel.com \
--cc=bigeasy@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=matwey@sai.msu.ru \
--cc=s.trumtrar@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).