From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B114C433EF for ; Fri, 15 Apr 2022 06:34:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346993AbiDOGhB (ORCPT ); Fri, 15 Apr 2022 02:37:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243518AbiDOGhA (ORCPT ); Fri, 15 Apr 2022 02:37:00 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D24AD36E24; Thu, 14 Apr 2022 23:34:32 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 726BC61F9B; Fri, 15 Apr 2022 06:34:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 644EBC385A6; Fri, 15 Apr 2022 06:34:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1650004471; bh=qOkWjTm4jX4AvkPwppg3cnPY3tsk8Meh+/ejuV0aSaU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qab4SoV02o5s+JFFSNc5BEgvyjc7BB3oKR/q0QtT5pYYHQn7YvFCdRII+zSaYCdlf Y24KZjR2JpXxKXLLLLzSCwiSmwwEeyLn8SnYg8i/WaAo5YNrDa5WYw4iThlmFUBTmO zGUpnLdZLzd5lfOVNs/C1Wbdd4CfO7YfWsBs8tSQ= Date: Fri, 15 Apr 2022 08:34:28 +0200 From: Greg KH To: "D. Starke" Cc: linux-serial@vger.kernel.org, jirislaby@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 19/20] tty: n_gsm: fix wrong behavior of gsm_carrier_raised() on debug Message-ID: References: <20220414094225.4527-1-daniel.starke@siemens.com> <20220414094225.4527-19-daniel.starke@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220414094225.4527-19-daniel.starke@siemens.com> Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Thu, Apr 14, 2022 at 02:42:24AM -0700, D. Starke wrote: > From: Daniel Starke > > gsm_carrier_raised() returns always 1 if the kernel module parameter > 'debug' has its second least significant bit set. This changes the behavior > of the module instead of just adding some debug output. > Remove this 'debug' gated early out to avoid debug settings from changing > the program flow. > > Fixes: e1eaea46bb40 ("tty: n_gsm line discipline") > Cc: stable@vger.kernel.org Why is this relevant for stable backporting? It's a debugging feature only, and you are changing how it previously worked :(