From: Greg KH <gregkh@linuxfoundation.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: linux-serial@vger.kernel.org, "Jiri Slaby" <jirislaby@kernel.org>,
"Lukas Wunner" <lukas@wunner.de>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Vicente Bergas" <vicencb@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Johan Hovold" <johan@kernel.org>,
heiko@sntech.de, giulio.benetti@micronovasrl.com,
"Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
"Raymond Tan" <raymond.tan@intel.com>
Subject: Re: [PATCH v4 04/13] serial: 8250_dwlib: RS485 HW half & full duplex support
Date: Tue, 26 Apr 2022 13:29:44 +0200 [thread overview]
Message-ID: <YmfXqK1KaX7XoJd8@kroah.com> (raw)
In-Reply-To: <20220425143410.12703-5-ilpo.jarvinen@linux.intel.com>
On Mon, Apr 25, 2022 at 05:34:01PM +0300, Ilpo Järvinen wrote:
> The Synopsys DesignWare UART can be configured to have HW support for
> the RS485 protocol from IP version 4.0 onward. Add support for
> hardware-controlled half duplex and full duplex modes.
>
> HW will take care of managing DE and RE, the driver just gives it
> permission to use either by setting both to 1.
>
> To ask for full duplex mode, userspace sets SER_RS485_RX_DURING_TX flag
> and HW will take care of the rest.
>
> Set delay_rts_before_send and delay_rts_after_send to zero for now. The
> granularity of that ABI is too coarse to be useful.
>
> Co-developed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Co-developed-by: Raymond Tan <raymond.tan@intel.com>
> Signed-off-by: Raymond Tan <raymond.tan@intel.com>
> Co-developed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---
> drivers/tty/serial/8250/8250_dwlib.c | 85 +++++++++++++++++++++++++++-
> drivers/tty/serial/8250/8250_dwlib.h | 3 +
> 2 files changed, 86 insertions(+), 2 deletions(-)
This commit fails to apply to my tree. Can you rebase this and the rest
and resend?
thanks,
greg k-h
next prev parent reply other threads:[~2022-04-26 11:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 14:33 [PATCH v4 00/13] Add RS485 support to DW UART Ilpo Järvinen
2022-04-25 14:33 ` [PATCH v4 01/13] serial: Store character timing information to uart_port Ilpo Järvinen
2022-04-25 14:33 ` [PATCH v4 02/13] serial: 8250: use THRE & __stop_tx also with DMA Ilpo Järvinen
2022-04-25 14:34 ` [PATCH v4 03/13] serial: 8250: Handle UART without interrupt on TEMT Ilpo Järvinen
2022-04-25 14:34 ` [PATCH v4 04/13] serial: 8250_dwlib: RS485 HW half & full duplex support Ilpo Järvinen
2022-04-26 11:29 ` Greg KH [this message]
2022-09-20 11:37 ` Lukas Wunner
2022-09-20 12:01 ` Ilpo Järvinen
2022-09-20 12:10 ` Lukas Wunner
2022-04-25 14:34 ` [PATCH v4 05/13] serial: 8250_dwlib: Implement SW half " Ilpo Järvinen
2022-04-25 14:34 ` [PATCH v4 06/13] dt_bindings: rs485: Add receiver enable polarity Ilpo Järvinen
2022-04-25 14:34 ` [PATCH v4 07/13] ACPI / property: Document RS485 _DSD properties Ilpo Järvinen
2022-04-25 14:34 ` [PATCH v4 08/13] serial: termbits: ADDRB to indicate 9th bit addressing mode Ilpo Järvinen
2022-04-25 14:34 ` [PATCH v4 09/13] serial: General support for multipoint addresses Ilpo Järvinen
2022-04-25 14:34 ` [PATCH v4 10/13] serial: 8250: make saved LSR larger Ilpo Järvinen
2022-04-25 14:34 ` [PATCH v4 11/13] serial: 8250: create lsr_save_mask Ilpo Järvinen
2022-04-25 14:34 ` [PATCH v4 12/13] serial: 8250_lpss: Use 32-bit reads Ilpo Järvinen
2022-04-25 14:34 ` [PATCH v4 13/13] serial: 8250_dwlib: Support for 9th bit multipoint addressing Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmfXqK1KaX7XoJd8@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=giulio.benetti@micronovasrl.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=heiko@sntech.de \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=raymond.tan@intel.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vicencb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).