From: Greg KH <gregkh@linuxfoundation.org>
To: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
Cc: linux-serial@vger.kernel.org, michal.simek@xilinx.com,
jirislaby@kernel.org, git@xilinx.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/7] tty: xilinx_uartps: fixes and improvements
Date: Thu, 5 May 2022 22:48:54 +0200 [thread overview]
Message-ID: <YnQ4Ngu8xt7DBi5C@kroah.com> (raw)
In-Reply-To: <20220429081422.3630070-1-shubhrajyoti.datta@xilinx.com>
On Fri, Apr 29, 2022 at 01:44:15PM +0530, Shubhrajyoti Datta wrote:
> Many of the stuff is reported by static analysis
> changes are
>
> - Update the copyright text
> - Check the return valuesof runtime and clock enable calls
> - Check the ignore_status in the isr
> - Prevent writing to the fifo when controller is disabled.
>
> Michal Simek (1):
> xilinx: Update copyright text to correct format
>
> Shubhrajyoti Datta (6):
> tty: xilinx_uartps: Check the clk_enable return value
> tty: xilinx_uartps: Add check for runtime_get_sync calls
> tty: xilinx_uartps: Check clk_enable return type
> tty: xilinx_uartps: Make the timeout unsigned
> serial: uartps: Fix the ignore_status
> serial: uartps: Prevent writes when the controller is disabled
Nit, why is the subject line prefix not unified here? Shouldn't they
all be "tty: xilinx_uartps:" like 4 of them are?
Can you fix up and resend?
thanks,
greg k-h
next prev parent reply other threads:[~2022-05-05 22:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 8:14 [PATCH 0/7] tty: xilinx_uartps: fixes and improvements Shubhrajyoti Datta
2022-04-29 8:14 ` [PATCH 1/7] xilinx: Update copyright text to correct format Shubhrajyoti Datta
2022-04-29 8:14 ` [PATCH 2/7] tty: xilinx_uartps: Check the clk_enable return value Shubhrajyoti Datta
2022-05-05 20:50 ` Greg KH
2022-07-28 11:09 ` Datta, Shubhrajyoti
2022-07-28 11:48 ` Greg KH
2022-04-29 8:14 ` [PATCH 3/7] tty: xilinx_uartps: Add check for runtime_get_sync calls Shubhrajyoti Datta
2022-05-05 20:50 ` Greg KH
2022-05-10 11:53 ` Shubhrajyoti Datta
2022-04-29 8:14 ` [PATCH 4/7] tty: xilinx_uartps: Check clk_enable return value Shubhrajyoti Datta
2022-05-05 20:51 ` Greg KH
2022-04-29 8:14 ` [PATCH 5/7] tty: xilinx_uartps: Make the timeout unsigned Shubhrajyoti Datta
2022-05-05 20:54 ` Greg KH
2022-04-29 8:14 ` [PATCH 6/7] serial: uartps: Fix the ignore_status Shubhrajyoti Datta
2022-05-05 20:55 ` Greg KH
2022-04-29 8:14 ` [PATCH 7/7] serial: uartps: Prevent writes when the controller is disabled Shubhrajyoti Datta
2022-05-05 20:56 ` Greg KH
2022-05-05 20:48 ` Greg KH [this message]
2022-05-10 11:54 ` [PATCH 0/7] tty: xilinx_uartps: fixes and improvements Shubhrajyoti Datta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnQ4Ngu8xt7DBi5C@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=git@xilinx.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=shubhrajyoti.datta@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).