linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Starke, Daniel" <daniel.starke@siemens.com>
Cc: "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
	"jirislaby@kernel.org" <jirislaby@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 6/9] tty: n_gsm: fix deadlock and link starvation in outgoing data path
Date: Mon, 27 Jun 2022 13:54:53 +0200	[thread overview]
Message-ID: <YrmajcyijzquuFui@kroah.com> (raw)
In-Reply-To: <DB9PR10MB5881188AE33199085DAD1460E0B59@DB9PR10MB5881.EURPRD10.PROD.OUTLOOK.COM>

On Thu, Jun 23, 2022 at 12:26:27PM +0000, Starke, Daniel wrote:
> > This is a bit huge for stable backports, especially given that a huge
> > number of the previous stable backports have totally failed and no one
> > has submitted new versions.
> > 
> > So why is this needed for stable?  Same for all of these in the series...
> 
> Given the fact that these are all bug fixes I assumed that these are also
> relevant for backporting. Maybe only in the more recent stable releases
> if there are issues with the merges.
> I do not mind removing the stable kernel reference and keep these changes
> only for mainline. So please let me know your preference.
> Should I resubmit the patches without stable reference?

Please read the stable kernel rules for what is, and is not allowed.
Generally a patch that does:
	drivers/tty/n_gsm.c | 410 ++++++++++++++++++++++++++++++--------------
is not allowed.

Please sort by what is stable fixes, and what is not.  Given that you
don't seem to want to backport patches to older stable kernels when they
fail to apply, why are any of these needed in stable kernels if the
older ones are not also going to be merged there?

thanks,

greg k-h

  reply	other threads:[~2022-06-27 12:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-23 12:26 [PATCH v3 6/9] tty: n_gsm: fix deadlock and link starvation in outgoing data path Starke, Daniel
2022-06-27 11:54 ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-06-28  9:41 Starke, Daniel
2022-06-30 14:59 ` Greg KH
2022-05-30 14:45 [PATCH v3 1/9] tty: n_gsm: fix user open not possible at responder until initiator open D. Starke
2022-05-30 14:45 ` [PATCH v3 6/9] tty: n_gsm: fix deadlock and link starvation in outgoing data path D. Starke
2022-06-10 11:55   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YrmajcyijzquuFui@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=daniel.starke@siemens.com \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).