From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D10BCCA479 for ; Tue, 28 Jun 2022 13:51:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345948AbiF1Nvm (ORCPT ); Tue, 28 Jun 2022 09:51:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345906AbiF1Nvm (ORCPT ); Tue, 28 Jun 2022 09:51:42 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18F392CE3B; Tue, 28 Jun 2022 06:51:41 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A9CED618F7; Tue, 28 Jun 2022 13:51:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83AF6C3411D; Tue, 28 Jun 2022 13:51:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1656424300; bh=tavwUDptky926TBvCoHB46pswP2jEsYYHlFbhtrikbY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nlAkrFvSDeqAOF4EqhNtymAfoIea1Fm0mYKul9EXHS817F1aLRvx3/MYMEA9mve7u qKiEcgm5UhoCUFY8XntpnIlprm0uW8B1wLDCftkp7cu1m2x9SUgJ4XuTJvZ1Yvav8n 3Gf34qvdER1x6h4h1AXSF5V15uK208DHdc/Y2oXA= Date: Tue, 28 Jun 2022 15:51:37 +0200 From: Greg Kroah-Hartman To: Chanho Park Cc: Krzysztof Kozlowski , Jiri Slaby , Alim Akhtar , Hector Martin , Jaewon Kim , Vincent Whitchurch , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2] tty: serial: samsung_tty: loopback mode support Message-ID: References: <20220628124050.144398-1-chanho61.park@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220628124050.144398-1-chanho61.park@samsung.com> Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Tue, Jun 28, 2022 at 09:40:50PM +0900, Chanho Park wrote: > Internal loopback mode can be supported by setting > UCON register's Loopback Mode bit. The mode & bit can be supported since > s3c2410 and later SoCs. The prefix of LOOPBACK / BIT(5) naming should be > also changed to S3C2410_ to avoid confusion. > > We can test it by linux-serial-test program > with -k option. The tool will set TIOCM_LOOP mode when the option is > specified. > -k, --loopback Use internal hardware loop back Again, what does this line mean in a changelog text? And properly wrap your lines at 72 columns. thanks, greg k-h