From: Thierry Reding <thierry.reding@gmail.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-serial@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [PATCH v2 5/5] serial: tegra: Remove custom frame size calculation
Date: Thu, 15 Sep 2022 14:33:16 +0200 [thread overview]
Message-ID: <YyMbjFMguOjiP0kV@orome> (raw)
In-Reply-To: <20220830084925.5608-6-ilpo.jarvinen@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 488 bytes --]
On Tue, Aug 30, 2022 at 11:49:25AM +0300, Ilpo Järvinen wrote:
> The number of bits can be calculated using tty_get_frame_size(), no
> need for the driver to do it on its own.
>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---
> drivers/tty/serial/serial-tegra.c | 12 +++---------
> 1 file changed, 3 insertions(+), 9 deletions(-)
Looks fine:
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2022-09-15 12:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 8:49 [PATCH v2 0/5] serial: Remove custom frame size calculation Ilpo Järvinen
2022-08-30 8:49 ` [PATCH v2 1/5] serial: ucc_uart: " Ilpo Järvinen
2022-08-30 17:01 ` Timur Tabi
2022-08-30 8:49 ` [PATCH v2 2/5] serial: cpm_uart: " Ilpo Järvinen
2022-08-30 8:49 ` [PATCH v2 3/5] serial: fsl_lpuart: " Ilpo Järvinen
2022-08-30 8:49 ` [PATCH v2 4/5] serial: sunsab: Remove frame size calculation dead-code Ilpo Järvinen
2022-08-30 8:49 ` [PATCH v2 5/5] serial: tegra: Remove custom frame size calculation Ilpo Järvinen
2022-09-15 12:33 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyMbjFMguOjiP0kV@orome \
--to=thierry.reding@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).