Re: [PATCH v4 09/13] serial: sh-sci: Introduced sci_of_data

[Wolfram Sang <wsa+renesas@sang-engineering.com>]

[-- Attachment #1: Type: text/plain, Size: 1186 bytes --]

On Thu, Mar 06, 2025 at 04:24:43PM +0100, Thierry Bultel wrote:
> The aim here is to provide an easier support to more different SCI
> controllers, like the RZ/T2H one.
> 
> The existing .data field of_sci_match is changed to a structure containing
> all what that can be statically initialized, and avoid a call to
> 'sci_probe_regmap', in both 'sci_init_single', and 'early_console_setup'.
> 
> 'sci_probe_regmap' is now assumed to be called in the only case where the
> device description is from a board file instead of a dts.
> 
> In this way, there is no need to patch 'sci_probe_regmap' for adding new
> SCI type, and also, the specific sci_port_params for a new SCI type can be
> provided by an external file.
> 
> Signed-off-by: Thierry Bultel <thierry.bultel.yh@bp.renesas.com>

Same comments about not-per-line-reviewed from me and much testing
needed as for patch 8. So:

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

>  	}, {
>  		.compatible = "renesas,rcar-gen4-scif",
> -		.data = SCI_OF_DATA(PORT_SCIF, SCIx_SH4_SCIF_BRG_REGTYPE),
> +		.data = &of_sci_rcar_scif
>  	},

This change to a proper struct is really nice IMHO!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]