From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Jiri Slaby <jirislaby@kernel.org>
Subject: Re: [PATCH v1 1/1] serial: 8250_port: Assign UPIO_UNKNOWN instead of its direct value
Date: Mon, 25 Nov 2024 12:52:07 +0200 [thread overview]
Message-ID: <Z0RW19I9VsuBlTL-@smile.fi.intel.com> (raw)
In-Reply-To: <ce88e017-9c2a-4963-a64c-9893e12cf6ea@app.fastmail.com>
On Mon, Nov 25, 2024 at 11:45:32AM +0100, Arnd Bergmann wrote:
> On Mon, Nov 25, 2024, at 11:33, Andy Shevchenko wrote:
> > serial8250_init_port() assings 0xFF for the unset or unknown port
> > IO type, use predefined constant for that instead.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
Thank you!
> I already thought about sending the same thing, but was going
> to wait until we have found a solution to the
> !CONFIG_HAS_IOPORT warning.
But it seems orthogonal to that... The solution in any case will
be more verbose and intrusive than this one-liner, I think.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-11-25 10:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-25 10:33 [PATCH v1 1/1] serial: 8250_port: Assign UPIO_UNKNOWN instead of its direct value Andy Shevchenko
2024-11-25 10:45 ` Arnd Bergmann
2024-11-25 10:52 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z0RW19I9VsuBlTL-@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=arnd@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).