[PATCH v1 1/1] serial: 8250_port: Assign UPIO_UNKNOWN instead of its direct value

[PATCH v1 1/1] serial: 8250_port: Assign UPIO_UNKNOWN instead of its direct value

[Andy Shevchenko]

serial8250_init_port() assings 0xFF for the unset or unknown port
IO type, use predefined constant for that instead.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/tty/serial/8250/8250_port.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c
index 4d63d80e78a9..1003516097df 100644
--- a/drivers/tty/serial/8250/8250_port.c
+++ b/drivers/tty/serial/8250/8250_port.c
@@ -3249,7 +3249,7 @@ void serial8250_init_port(struct uart_8250_port *up)
 	port->ops = &serial8250_pops;
 	port->has_sysrq = IS_ENABLED(CONFIG_SERIAL_8250_CONSOLE);
 
-	up->cur_iotype = 0xFF;
+	up->cur_iotype = UPIO_UNKNOWN;
 }
 EXPORT_SYMBOL_GPL(serial8250_init_port);
 
-- 
2.43.0.rc1.1336.g36b5255a03ac

Re: [PATCH v1 1/1] serial: 8250_port: Assign UPIO_UNKNOWN instead of its direct value

[Arnd Bergmann]

On Mon, Nov 25, 2024, at 11:33, Andy Shevchenko wrote:
> serial8250_init_port() assings 0xFF for the unset or unknown port
> IO type, use predefined constant for that instead.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Acked-by: Arnd Bergmann <arnd@arndb.de>

I already thought about sending the same thing, but was going
to wait until we have found a solution to the
!CONFIG_HAS_IOPORT warning.

      Arnd

Re: [PATCH v1 1/1] serial: 8250_port: Assign UPIO_UNKNOWN instead of its direct value

[Andy Shevchenko]

On Mon, Nov 25, 2024 at 11:45:32AM +0100, Arnd Bergmann wrote:
> On Mon, Nov 25, 2024, at 11:33, Andy Shevchenko wrote:
> > serial8250_init_port() assings 0xFF for the unset or unknown port
> > IO type, use predefined constant for that instead.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> Acked-by: Arnd Bergmann <arnd@arndb.de>

Thank you!

> I already thought about sending the same thing, but was going
> to wait until we have found a solution to the
> !CONFIG_HAS_IOPORT warning.

But it seems orthogonal to that... The solution in any case will
be more verbose and intrusive than this one-liner, I think.

-- 
With Best Regards,
Andy Shevchenko