From: Yu-Chun Lin <eleanor15x@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: jirislaby@kernel.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, jserv@ccns.ncku.edu.tw,
visitorckw@gmail.com, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] serial: pic32: Fix build warning when CONFIG_OF is disabled
Date: Mon, 27 Jan 2025 18:07:13 +0800 [thread overview]
Message-ID: <Z5da0aCupnXRvjr9@eleanor-wkdl> (raw)
In-Reply-To: <2025012726-macaroni-unbiased-e6c3@gregkh>
On Mon, Jan 27, 2025 at 10:12:47AM +0100, Greg KH wrote:
> > So I should remove of_match_ptr and add the CONFIG_OF as a dependency
> > for the configuration. Correct?
>
> I don't know, but putting #ifdef in .c files is not the correct solution
> at all.
I fixed the build warning this way because I saw it was done the same way
in these three files:
drivers/tty/serial/samsung_tty.c
drivers/tty/serial/mps2-uart.c
drivers/tty/serial/altera_jtaguart.c
Or maybe we can add __maybe_unused to avoid the warning?
Yu-Chun Lin
next prev parent reply other threads:[~2025-01-27 10:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-26 16:31 [PATCH] serial: pic32: Fix build warning when CONFIG_OF is disabled Yu-Chun Lin
2025-01-26 19:30 ` Greg KH
2025-01-27 8:29 ` Yu-Chun Lin
2025-01-27 9:12 ` Greg KH
2025-01-27 10:07 ` Yu-Chun Lin [this message]
2025-01-27 10:21 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z5da0aCupnXRvjr9@eleanor-wkdl \
--to=eleanor15x@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=jserv@ccns.ncku.edu.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lkp@intel.com \
--cc=visitorckw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox