From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Douglas Anderson <dianders@chromium.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Daniel Thompson <danielt@kernel.org>,
"Dr . David Alan Gilbert" <linux@treblig.org>,
kgdb-bugreport@lists.sourceforge.net,
Anton Vorontsov <anton.vorontsov@linaro.org>,
Sumit Garg <sumit.garg@linaro.org>,
linux-serial@vger.kernel.org, Arnd Bergmann <arnd@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Hugo Villeneuve <hvilleneuve@dimonoff.com>,
Jason Wessel <jason.wessel@windriver.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Niklas Schnelle <schnelle@linux.ibm.com>,
Robert Marko <robert.marko@sartura.hr>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] Revert "tty/serial: Add kgdb_nmi driver"
Date: Thu, 30 Jan 2025 10:27:29 +0200 [thread overview]
Message-ID: <Z5s38S7sJ2mka3-1@smile.fi.intel.com> (raw)
In-Reply-To: <20250129082535.1.Ia095eac1ae357f87d23e7af2206741f5d40788f1@changeid>
On Wed, Jan 29, 2025 at 08:25:50AM -0800, Douglas Anderson wrote:
> This reverts commit 0c57dfcc6c1d037243c2f8fbf62eab3633326ec0.
>
> The functionality was supoosed to be used by a later patch in the
> series that never landed [1]. Drop it.
>
> NOTE: part of functionality was already reverted by commit
> 39d0be87438a ("serial: kgdb_nmi: Remove unused knock code"). Also note
> that this revert is not a clean revert given code changes that have
> happened in the meantime.
>
> It's obvious that nobody is using this code since the two exposed
> functions (kgdb_register_nmi_console() and
> kgdb_unregister_nmi_console()) are both no-ops if
> "arch_kgdb_ops.enable_nmi" is not defined. No architectures define it.
Fine with me.
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> [1] https://lore.kernel.org/lkml/1348522080-32629-9-git-send-email-anton.vorontsov@linaro.org/
It might be possible to use Link tag here in a form
Link: URL [1]
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-01-30 8:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-29 16:25 [PATCH 0/3] kdb: Delete never used KGDB NMI code Douglas Anderson
2025-01-29 16:25 ` [PATCH 1/3] Revert "tty/serial: Add kgdb_nmi driver" Douglas Anderson
2025-01-30 8:27 ` Andy Shevchenko [this message]
2025-01-30 8:32 ` Andy Shevchenko
2025-01-30 16:31 ` Andy Shevchenko
2025-01-29 16:25 ` [PATCH 2/3] Revert "kdb: Implement disable_nmi command" Douglas Anderson
2025-01-29 16:25 ` [PATCH 3/3] Revert "kernel/debug: Mask KGDB NMI upon entry" Douglas Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z5s38S7sJ2mka3-1@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=anton.vorontsov@linaro.org \
--cc=arnd@kernel.org \
--cc=danielt@kernel.org \
--cc=dianders@chromium.org \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=hvilleneuve@dimonoff.com \
--cc=jason.wessel@windriver.com \
--cc=jirislaby@kernel.org \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@treblig.org \
--cc=nicolas.ferre@microchip.com \
--cc=robert.marko@sartura.hr \
--cc=schnelle@linux.ibm.com \
--cc=sumit.garg@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox