Regression on linux-next (next-20250210)

Regression on linux-next (next-20250210)

[Borah, Chaitanya Kumar]

Hello Andy,

Hope you are doing well. I am Chaitanya from the linux graphics team in Intel.

This mail is regarding a regression we are seeing in our CI runs[1] on linux-next repository.

Since the version next-20250210 [2], many machines in our CI are unable to boot.

Unfortunately, we have  not been able to collect any logs (even from pstore).

However after bisecting the tree, the following patch [3] seems to be the first "bad"
commit

`````````````````````````````````````````````````````````````````````````````````````````````````````````
commit bfd3d4a40f3905ec70b17dbfa9b78764e59e4b4f
Author: Andy Shevchenko mailto:andriy.shevchenko@linux.intel.com
Date:   Mon Feb 3 14:14:56 2025 +0200

    serial: 8250_dw: Drop unneeded NULL checks in dw8250_quirks()

    Since platform data is being provided for all supported hardware,
    no need to NULL check for it. Drop unneeded checks.

`````````````````````````````````````````````````````````````````````````````````````````````````````````

We also verified that if we revert the patch the issue is not seen.

Could you please check why the patch causes this regression and provide a fix if necessary?

Thank you.

Regards

Chaitanya

[1] https://intel-gfx-ci.01.org/tree/linux-next/combined-alt.html?
[2] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20250210
[3] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20250210&id=bfd3d4a40f3905ec70b17dbfa9b78764e59e4b4f 

Re: Regression on linux-next (next-20250210)

[andriy.shevchenko]

The fix landed upstream, will be in next Linux Next.

c213375e3283 ("serial: 8250_dw: Call dw8250_quirks() conditionally")


On Sat, Feb 15, 2025 at 04:16:58PM +0000, Borah, Chaitanya Kumar wrote:
> Hello Andy,
> 
> Hope you are doing well. I am Chaitanya from the linux graphics team in Intel.
> 
> This mail is regarding a regression we are seeing in our CI runs[1] on linux-next repository.
> 
> Since the version next-20250210 [2], many machines in our CI are unable to boot.
> 
> Unfortunately, we have  not been able to collect any logs (even from pstore).
> 
> However after bisecting the tree, the following patch [3] seems to be the first "bad"
> commit
> 
> `````````````````````````````````````````````````````````````````````````````````````````````````````````
> commit bfd3d4a40f3905ec70b17dbfa9b78764e59e4b4f
> Author: Andy Shevchenko mailto:andriy.shevchenko@linux.intel.com
> Date:   Mon Feb 3 14:14:56 2025 +0200
> 
>     serial: 8250_dw: Drop unneeded NULL checks in dw8250_quirks()
> 
>     Since platform data is being provided for all supported hardware,
>     no need to NULL check for it. Drop unneeded checks.
> 
> `````````````````````````````````````````````````````````````````````````````````````````````````````````
> 
> We also verified that if we revert the patch the issue is not seen.
> 
> Could you please check why the patch causes this regression and provide a fix if necessary?
> 
> Thank you.
> 
> Regards
> 
> Chaitanya
> 
> [1] https://intel-gfx-ci.01.org/tree/linux-next/combined-alt.html?
> [2] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20250210
> [3] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20250210&id=bfd3d4a40f3905ec70b17dbfa9b78764e59e4b4f 
> 
> 

-- 
With Best Regards,
Andy Shevchenko

RE: Regression on linux-next (next-20250210)

[Borah, Chaitanya Kumar]

> -----Original Message-----
> From: andriy.shevchenko@linux.intel.com
> <andriy.shevchenko@linux.intel.com>
> Sent: Monday, February 17, 2025 1:43 AM
> To: Borah, Chaitanya Kumar <chaitanya.kumar.borah@intel.com>
> Cc: linux-serial@vger.kernel.org; intel-gfx@lists.freedesktop.org; intel-
> xe@lists.freedesktop.org; Kurmi, Suresh Kumar
> <suresh.kumar.kurmi@intel.com>; Saarinen, Jani <jani.saarinen@intel.com>
> Subject: Re: Regression on linux-next (next-20250210)
> 
> 
> The fix landed upstream, will be in next Linux Next.
> 
> c213375e3283 ("serial: 8250_dw: Call dw8250_quirks() conditionally")

Thank you for the response. We will wait for it to land in linux-next.

Regards

Chaitanya

> 
> 
> On Sat, Feb 15, 2025 at 04:16:58PM +0000, Borah, Chaitanya Kumar wrote:
> > Hello Andy,
> >
> > Hope you are doing well. I am Chaitanya from the linux graphics team in
> Intel.
> >
> > This mail is regarding a regression we are seeing in our CI runs[1] on linux-
> next repository.
> >
> > Since the version next-20250210 [2], many machines in our CI are unable to
> boot.
> >
> > Unfortunately, we have  not been able to collect any logs (even from pstore).
> >
> > However after bisecting the tree, the following patch [3] seems to be the first
> "bad"
> > commit
> >
> > ``````````````````````````````````````````````````````````````````````
> > ```````````````````````````````````
> > commit bfd3d4a40f3905ec70b17dbfa9b78764e59e4b4f
> > Author: Andy Shevchenko mailto:andriy.shevchenko@linux.intel.com
> > Date:   Mon Feb 3 14:14:56 2025 +0200
> >
> >     serial: 8250_dw: Drop unneeded NULL checks in dw8250_quirks()
> >
> >     Since platform data is being provided for all supported hardware,
> >     no need to NULL check for it. Drop unneeded checks.
> >
> > ``````````````````````````````````````````````````````````````````````
> > ```````````````````````````````````
> >
> > We also verified that if we revert the patch the issue is not seen.
> >
> > Could you please check why the patch causes this regression and provide a
> fix if necessary?
> >
> > Thank you.
> >
> > Regards
> >
> > Chaitanya
> >
> > [1] https://intel-gfx-ci.01.org/tree/linux-next/combined-alt.html?
> > [2]
> > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/co
> > mmit/?h=next-20250210 [3]
> > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/co
> > mmit/?h=next-
> 20250210&id=bfd3d4a40f3905ec70b17dbfa9b78764e59e4b4f
> >
> >
> 
> --
> With Best Regards,
> Andy Shevchenko
>