From: Petr Mladek <pmladek@suse.com>
To: adamsimonelli@gmail.com
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Jiri Slaby <jirislaby@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
John Ogness <john.ogness@linutronix.de>,
Sergey Senozhatsky <senozhatsky@chromium.org>
Subject: Re: [PATCH v8 4/4] Documentation/serial-console: Document CONFIG_NULL_TTY_DEFAULT_CONSOLE.
Date: Wed, 12 Mar 2025 16:40:42 +0100 [thread overview]
Message-ID: <Z9Gq-oIr8wPGLGEy@pathway.suse.cz> (raw)
In-Reply-To: <20250311033133.1859963-5-adamsimonelli@gmail.com>
On Mon 2025-03-10 23:31:33, adamsimonelli@gmail.com wrote:
> From: Adam Simonelli <adamsimonelli@gmail.com>
>
> When the kernel is compiled with CONFIG_NULL_TTY_DEFAULT_CONSOLE and
> no console= options are selected, it defaults to using the ttynull
> device.
There is a missing Signed-off-by.
The change looks fine to me. Feel free to use:
Reviewed-by: Petr Mladek <pmladek@suse.com>
That said, I would personally squash this into the patch adding
the CONFIG_NULL_TTY_DEFAULT_CONSOLE configure option.
Best Regards,
Petr
next prev parent reply other threads:[~2025-03-12 15:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 3:31 [PATCH v8 0/4] Optionally allow ttynull to be selected as a default console adamsimonelli
2025-03-11 3:31 ` [PATCH v8 1/4] ttynull: Always initialize console index to -1 adamsimonelli
2025-03-12 14:38 ` Petr Mladek
2025-03-13 12:09 ` Adam Simonelli
2025-03-11 3:31 ` [PATCH v8 2/4] ttynull: Add an option to allow ttynull to be used as a console device adamsimonelli
2025-03-12 15:37 ` Petr Mladek
2025-03-11 3:31 ` [PATCH v8 3/4] tty: Change order of ttynull to be linked sooner if enabled as a console adamsimonelli
2025-03-11 3:31 ` [PATCH v8 4/4] Documentation/serial-console: Document CONFIG_NULL_TTY_DEFAULT_CONSOLE adamsimonelli
2025-03-12 15:40 ` Petr Mladek [this message]
2025-03-11 19:50 ` [PATCH v8 0/4] Optionally allow ttynull to be selected as a default console Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9Gq-oIr8wPGLGEy@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=adamsimonelli@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox