From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Jiri Slaby <jirislaby@kernel.org>,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
linux-serial@vger.kernel.org, linux-arm-msm@vger.kernel.org,
kgdb-bugreport@lists.sourceforge.net,
Konrad Dybcio <konrad.dybcio@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] serial: uart_poll_init() should power on the UART
Date: Thu, 16 Mar 2023 12:59:10 +0100 [thread overview]
Message-ID: <ZBMEjp16fBNE33o4@kroah.com> (raw)
In-Reply-To: <CAD=FV=XFEYPbC64TFLVUmky=1Y-b_iyqiwrALvjKTM_NWr34Dg@mail.gmail.com>
On Mon, Mar 13, 2023 at 01:53:02PM -0700, Doug Anderson wrote:
> Hi,
>
> On Tue, Mar 7, 2023 at 7:32 AM Douglas Anderson <dianders@chromium.org> wrote:
> >
> > On Qualcomm devices which use the "geni" serial driver, kdb/kgdb won't
> > be very happy if you use it but the resources of the port haven't been
> > powered on. Today kdb/kgdb rely on someone else powering the port
> > on. This could be the normal kernel console or an agetty running.
> > Let's fix this to explicitly power things on when setting up a polling
> > driver.
> >
> > Signed-off-by: Douglas Anderson <dianders@chromium.org>
> > ---
> >
> > drivers/tty/serial/serial_core.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
>
> Just in case it's not obvious, even though we ended up going with
> Johan's series [1] instead of patch #1 of my series, patch #2 and #3
> of my series are still relevant. I can repost the series without patch
> #1 if it's helpful.
>
> [1] https://lore.kernel.org/r/20230307164405.14218-1-johan+linaro@kernel.org
Ye,s it's not obvious at all. Please resubmit.
thanks,
greg k-h
next prev parent reply other threads:[~2023-03-16 11:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 15:32 [PATCH 1/3] tty: serial: qcom-geni-serial: Fix kdb/kgdb after port shutdown (again) Douglas Anderson
2023-03-07 15:32 ` [PATCH 2/3] serial: uart_poll_init() should power on the UART Douglas Anderson
2023-03-13 20:53 ` Doug Anderson
2023-03-16 11:59 ` Greg Kroah-Hartman [this message]
2023-03-07 15:32 ` [PATCH 3/3] tty: serial: qcom-geni-serial: Add a poll_init() function Douglas Anderson
2023-03-07 15:38 ` [PATCH 1/3] tty: serial: qcom-geni-serial: Fix kdb/kgdb after port shutdown (again) Bartosz Golaszewski
2023-03-07 15:46 ` Bartosz Golaszewski
2023-03-07 16:01 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBMEjp16fBNE33o4@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andersson@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=dianders@chromium.org \
--cc=jirislaby@kernel.org \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).