From: Thierry Reding <thierry.reding@gmail.com>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Laxman Dewangan <ldewangan@nvidia.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-serial@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH] serial: tegra: Don't print error on probe deferral
Date: Mon, 3 Jul 2023 17:03:45 +0200 [thread overview]
Message-ID: <ZKLjUdBdC0vVknsk@orome> (raw)
In-Reply-To: <20230703113759.75608-1-jonathanh@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1021 bytes --]
On Mon, Jul 03, 2023 at 12:37:59PM +0100, Jon Hunter wrote:
> If the Tegra serial driver is probe before clocks are available then the
> following error is seen on boot:
>
> serial-tegra 3100000.serial: Couldn't get the clock
>
> This has been observed on Jetson AGX Orin. Fix this by calling
> dev_err_probe() instead of dev_err() to avoid printing an error on probe
> deferral.
>
> Fixes: e9ea096dd225 ("serial: tegra: add serial driver")
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
> drivers/tty/serial/serial-tegra.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
Patch looks good to me, though I'm not sure the Fixes: tag is useful. It
points to a commit that is 10 years old and the error message is
probably not worth backporting to every single actively maintained
stable release. I'm not sure it's worth backporting at all because it's
purely cosmetic.
That's up to Greg and Jiri, so from the Tegra side:
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2023-07-03 15:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 11:37 [PATCH] serial: tegra: Don't print error on probe deferral Jon Hunter
2023-07-03 15:03 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKLjUdBdC0vVknsk@orome \
--to=thierry.reding@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-serial@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).