From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65F9FC001B0 for ; Fri, 14 Jul 2023 15:08:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236131AbjGNPIH (ORCPT ); Fri, 14 Jul 2023 11:08:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234425AbjGNPIG (ORCPT ); Fri, 14 Jul 2023 11:08:06 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6086F2702; Fri, 14 Jul 2023 08:08:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F349761D48; Fri, 14 Jul 2023 15:08:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 591D0C433C7; Fri, 14 Jul 2023 15:08:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689347284; bh=ocPhOzFijupIUUD2Bp7JtiNo8d0/cn/ky2mmjm36hgQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RcszFiUEGzq3FlUItGxNuvKWEHBh1AfacWryEi7hRHmCJ4Fd51i5qSG18fpY+OoNM as8q7Ii0vpGch75W8Tqc5213EyPArf+Um+Ic3cT47a/lfbyL7rwZboh/m/Yyevdc7A erYd1dUsqwryTaIohi60la+dY8EVLXwvJTlf3/tDcE3hlwdSoeKM3xKVKxVxprLoVz Vwh5sXKBmLQuRWFmOgtcaXx7CStoALoolBrdO1aYmDhVU++VNpmTWxtEmLUQ4ZsjAW Yf+8SgCp1dMQb64QanX1u9q8bKDcPQWQBhR/D62RAHmdYAqsuc1naL2IWaDyQE9lqT S+YTUzUN7dfpA== Received: from johan by xi.lan with local (Exim 4.96) (envelope-from ) id 1qKKOr-0004qL-0l; Fri, 14 Jul 2023 17:08:05 +0200 Date: Fri, 14 Jul 2023 17:08:05 +0200 From: Johan Hovold To: Konrad Dybcio Cc: Johan Hovold , Greg Kroah-Hartman , Andy Gross , Bjorn Andersson , Jiri Slaby , linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Rajendra Nayak , Matthias Kaehlcke Subject: Re: [PATCH 1/2] serial: qcom-geni: fix opp vote on shutdown Message-ID: References: <20230714130214.14552-1-johan+linaro@kernel.org> <20230714130214.14552-2-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Fri, Jul 14, 2023 at 04:29:08PM +0200, Konrad Dybcio wrote: > On 14.07.2023 15:02, Johan Hovold wrote: > > The operating-performance-point vote needs to be dropped when shutting > > down the port to avoid wasting power by keeping resources like power > > domains in an unnecessarily high performance state (e.g. when a UART > > connected Bluetooth controller is not in use). > > > > Fixes: a5819b548af0 ("tty: serial: qcom_geni_serial: Use OPP API to set clk/perf state") > > Cc: stable@vger.kernel.org # 5.9 > > Cc: Rajendra Nayak > > Cc: Matthias Kaehlcke > > Signed-off-by: Johan Hovold > > --- > I don't know a whole lot about this subsystem, but the PM call has > a pointer to uport which already contains this clock rate.. Is it > zeroed out by the core before we reach it, which would prevent us > from reusing it? No, but this driver has other issues and I couldn't be arsed fixing them before addressing this bug. Specifically that uartclk variable can currently be set by userspace... I'll fix that up next week. Johan