From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: "Tony Lindgren" <tony@atomide.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Dhruva Gole" <d-gole@ti.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"John Ogness" <john.ogness@linutronix.de>,
"Johan Hovold" <johan@kernel.org>,
"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
linux-omap@vger.kernel.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: core: Fix serial core port id to not use port->line
Date: Wed, 19 Jul 2023 08:34:31 +0300 [thread overview]
Message-ID: <ZLd154hdaSG2lnue@smile.fi.intel.com> (raw)
In-Reply-To: <82c49602-8c6e-51c2-6f73-28fb9b458db8@kernel.org>
On Wed, Jul 19, 2023 at 07:26:41AM +0200, Jiri Slaby wrote:
> On 19. 07. 23, 7:12, Tony Lindgren wrote:
...
> > int ctrl_id; /* optional serial core controller id */
> > + int port_id; /* optional serial core port id */
>
> Can the id be negative? If not, please use uint.
Does this suggestion apply to ctrl_id as well?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-07-19 5:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 5:12 [PATCH] serial: core: Fix serial core port id to not use port->line Tony Lindgren
2023-07-19 5:26 ` Jiri Slaby
2023-07-19 5:34 ` Andy Shevchenko [this message]
2023-07-19 5:37 ` Jiri Slaby
2023-07-19 5:50 ` Tony Lindgren
2023-07-19 5:28 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLd154hdaSG2lnue@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bigeasy@linutronix.de \
--cc=d-gole@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).